Re: pkg/34591: Patch file that fixed DNS lookup problems in www/dillo was mistak

["David H. GUTTERIDGE" <dhgutteridge%sympatico.ca@localhost>]

The following reply was made to PR pkg/34591; it has been noted by GNATS.

From: "David H. GUTTERIDGE" <dhgutteridge%sympatico.ca@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/34591: Patch file that fixed DNS lookup problems in www/dillo 
was mistak
Date: Sat, 23 Sep 2006 17:21:30 +0000

 >  This would also apply to DragonFly, FreeBSD 4 and most likely OpenBSD.
 >  Not sure about the later though.
 >
 >  Joerg
 
 When I created the original patch I submitted, I emailed the DragonFly users 
 list
 to see if it would be relevant for that OS too, but didn't get any response, 
 I
 guess I should have just asked you, Joerg.
 
 FreeBSD changed this particular family of functions over to be reentrant in 
 their
 5.5 release.  From looking at OpenBSD's ports CVS I can see they've simply
 changed the dns.c file to prevent the threaded code from being compiled in, 
 so
 that suggests we can safely follow their method for now for their OS.
 
 I've attached a more comprehensive patch below that handles all four major 
 BSDs
 for this package, I hope it's to everyone's liking.  Tim (garbled@) was 
 hesitant about
 the idea of bluntly disabling something for a given OS, but I don't see any 
 other way
 to do it, if DragonFly BSD and OpenBSD don't have the functionality yet.
 
 Dave
 
 --- Makefile~  2006-09-22 22:43:11.000000000 -0400
 +++ Makefile   2006-09-23 13:12:01.000000000 -0400
 @@ -21,6 +21,20 @@
 
 .include "options.mk"
 
 +# NetBSD < 3.0 does not have reentrant resolver functions
 +.if ${OPSYS} == "NetBSD" && !empty(OS_VERSION:M[1-2].*)
 +CONFIGURE_ARGS+=      --disable-threaded-dns
 +# DragonFly BSD as of 1.6 does not have reentrant resolver functions
 +.elif ${OPSYS} == "DragonFly"
 +CONFIGURE_ARGS+=      --disable-threaded-dns
 +# OpenBSD as of 3.9 does not have reentrant resolver functions
 +.elif ${OPSYS} == "OpenBSD"
 +CONFIGURE_ARGS+=      --disable-threaded-dns
 +# FreeBSD < 5.5 does not have (applicable) reentrant resolver functions
 +.elif ${OPSYS} == "FreeBSD" && (!empty(OS_VERSION:M[1-4].*) || 
 !empty(OS_VERSION:M5.[0-4]*))
 +CONFIGURE_ARGS+=      --disable-threaded-dns
 +.endif
 +
 post-install:
        ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/dillo
        ${INSTALL_DATA} ${WRKSRC}/doc/*.txt ${PREFIX}/share/doc/dillo