pkg/34723: pkgsrc patch crashes links and links-gui

[Christian Biere <christianbiere%gmx.de@localhost>]

>Number:         34723
>Category:       pkg
>Synopsis:       pkgsrc patch crashes links and links-gui
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 05 16:55:00 +0000 2006
>Originator:     Christian Biere
>Release:        NetBSD 4.99.3
>Environment:
System: NetBSD cyclonus 4.99.3 NetBSD 4.99.3 (UNICRON.XEN3_DOM0) #4: Thu Oct 5 
07:33:26 CEST 2006 
src@cyclonus:/o/NetBSD/obj/sys/arch/i386/compile/UNICRON.XEN3_DOM0 i386
Architecture: i386
Machine: i386
>Description:
pkgsrc contains a patch for links and links-gui which adds a feature
that removes trailing spaces from URLs in session.c goto_url(). This
additional code contains at least two bugs: It modifies the URL in
place, ignoring that the passed memory might be read-only protected.
This causes a crash when calling built-in URLs. Also, if the URL
parameter is an empty string, the code may cause further havoc.

Please, request feature from the links developers and let them review
such patches before adding them to pkgsrc.

>How-To-Repeat:
Select About->Homepage from the menu.
>Fix:
Revert patch-aa of www/links to revision 1.2.