Re: pkg/34838: news/nn does not compile (NetBSD 3.0)

[Georg Schwarz <georg.schwarz%freenet.de@localhost>]

The following reply was made to PR pkg/34838; it has been noted by GNATS.

From: Georg Schwarz <georg.schwarz%freenet.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/34838: news/nn does not compile (NetBSD 3.0)
Date: Tue, 17 Oct 2006 19:29:31 +0200

 Am 17.10.2006 um 11:55 schrieb kre%munnari.OZ.AU@localhost:
 
 >> Description:
 >      I have no idea what systems news/nn actually compiles
 >      successfully on (except probably irix, where it looks to
 >      be handled), but as it is it uses sockaddr_in and (on most(?)
 >      systems) doesn't include netinet/in.h
 >
 
 it compiles fine on Darwin (PPC, so maybe the NETWORK_BYTE_ORDER  
 clause saved it?)
 
 >      which suggests that sockaddr_in isn't defined.
 >      And sure, enough, around lines 60-65 of nntp.c
 >      there appears ...
 >
 > /* This is necessary due to the definitions in m-XXX.h */
 > /* IRIX needs it for struct sockaddr_in */
 >
 > #if !defined(NETWORK_DATABASE) || defined(NETWORK_BYTE_ORDER) ||  
 > defined(__sgi)
 > #include <netinet/in.h>
 > #endif
 >
 >      which doesn't manage to include netinet/in.h on NetBSD systems.
 
 the same used to be true for IRIX before I introduced the extra  
 treatment through patch-ax
 
 >
 >> Fix:
 >
 >      Patching nntp.c to add
 >              || defined(__NetBSD__)
 >      to the #if allowed it to compile for me.
 
 
 please add that to patch-ax for systems that require it.
 
 
 
 
 -- 
 Georg Schwarz    http://home.pages.de/~schwarz/
 georg.schwarz%freenet.de@localhost  +49 178 8545053