Subject: pkg/34942: removing compiler warnings in pkgsrc/pkgtools/mtree
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Eric Schnoebelen <eric@cirr.com>
List: pkgsrc-bugs
Date: 10/29/2006 22:10:02
>Number: 34942
>Category: pkg
>Synopsis: remove compiler warnings in pkgsrc/pkgtools/mtree
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Oct 29 22:10:02 +0000 2006
>Originator: Eric Schnoebelen
>Release: HP-UX B.11.11
>Organization:
Eric Schnoebelen eric@cirr.com http://www.cirr.com
"The nice thing about Windows is - It does not just crash, it
displays a dialog box and lets you press 'OK' first." - Arno Schaefer
>Environment:
HP-UX peake B.11.11 A 9000/785 2006709503 two-user license
B3899BA B.11.11.06 HP C/ANSI C Developer's Bundle for HP-UX 11.i (S700)
B3911DB C.03.37.01 HP aC++ Compiler (S700)
FEATURE11-11 B.11.11.0209.5 Feature Enablement Patches for HP-UX 11i, Sept 2002
HPUX11i-TCOE B.11.11.0306 HP-UX Technical Computing OE Component
HPUXBase64 B.11.11 HP-UX 64-bit Base OS
HPUXBaseAux B.11.11.0312 HP-UX Base OS Auxiliary
HWEnable11i B.11.11.0312.4 Hardware Enablement Patches for HP-UX 11i v1, December 2003
[ok, the above is only really useful/interesting to an HP-UX weenie, or
the HP WTEC.]
>Description:
Several source files declare function prototypes as static
at the top, and then fail to repeat the static keyword when declaring
the actual function.
>How-To-Repeat:
compile with a very picky compiler, such as HP ANSI C.
>Fix:
Index: files/create.c
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/mtree/files/create.c,v
retrieving revision 1.4
diff -b -u -w -r1.4 create.c
--- files/create.c 21 Aug 2004 04:10:45 -0000 1.4
+++ files/create.c 29 Oct 2006 22:08:57 -0000
@@ -400,7 +400,7 @@
return (strcmp((*a)->fts_name, (*b)->fts_name));
}
-void
+static void
output(int *offset, const char *fmt, ...)
{
va_list ap;