pkg/35101: graphics/cairo 1.2.6 (hidden attribute for gcc AMD64 not valid)

["Gilles Dauphin" <dauphin%enst.fr@localhost>]

>Number:         35101
>Category:       pkg
>Synopsis:       graphics/cairo 1.2.6 (hidden attribute for gcc AMD64 not valid)
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 23 09:50:00 +0000 2006
>Originator:     Gilles Dauphin
>Release:        SunOS 5.10 i86pc
>Organization:
ENST 
>Environment:


System: SunOS bi.enst.fr 5.10 Generic_118855-19 i86pc


>Description:


gcc -shared -Wl,-h -Wl,libcairo.so.2 -o .libs/libcairo.so.2.9.3  .libs/cairo.o 
.libs/cairo-arc.o .libs/cairo-array.o .
libs/cairo-base85-stream.o .libs/cairo-cache.o .libs/cairo-clip.o 
.libs/cairo-color.o .libs/cairo-debug.o .libs/cairo-
fixed.o .libs/cairo-font.o .libs/cairo-font-options.o .libs/cairo-gstate.o 
.libs/cairo-hash.o .libs/cairo-hull.o .libs
/cairo-image-surface.o .libs/cairo-lzw.o .libs/cairo-matrix.o 
.libs/cairo-operator.o .libs/cairo-path.o .libs/cairo-pa
th-bounds.o .libs/cairo-path-data.o .libs/cairo-path-fill.o 
.libs/cairo-path-stroke.o .libs/cairo-pen.o .libs/cairo-po
lygon.o .libs/cairo-rectangle.o .libs/cairo-region.o .libs/cairo-scaled-font.o 
.libs/cairo-slope.o .libs/cairo-spline.
o .libs/cairo-stroke-style.o .libs/cairo-surface.o 
.libs/cairo-surface-fallback.o .libs/cairo-traps.o .libs/cairo-patt
ern.o .libs/cairo-unicode.o .libs/cairo-output-stream.o .libs/cairo-wideint.o 
.libs/cairo-meta-surface.o .libs/cairo-p
aginated-surface.o .libs/cairo-analysis-surface.o .libs/cairo-ft-font.o 
.libs/cairo-ps-surface.o .libs/cairo-pdf-surfa
ce.o .libs/cairo-png.o .libs/cairo-svg-surface.o .libs/cairo-truetype-subset.o 
.libs/cairo-scaled-font-subsets.o .libs
/cairo-type1-subset.o .libs/cairo-xlib-surface.o .libs/cairo-xlib-screen.o 
.libs/cairo-glitz-surface
.o -Wl,-z -Wl,allextract,../pixman/src/.libs/libpixman.a -Wl,-z 
-Wl,defaultextract  -R/pkg/obj/graphics/cairo/work/.bu
ildlink/lib -R/pkg/obj/graphics/cairo/work/.buildlink/lib -R/usr/pkg/lib 
-R/usr/openwin/lib/64 -L/pkg/obj/graphics/cai
ro/work/.buildlink/lib -L/pkg/obj/graphics/cairo/work/.x11-buildlink/lib/64 
/pkg/obj/graphics/cairo/work/.buildlink/li
b/libfreetype.so /pkg/obj/graphics/cairo/work/.buildlink/lib/libz.so 
/pkg/obj/graphics/cairo/work/.buildlink/lib/libfo
ntconfig.so /pkg/obj/graphics/cairo/work/.buildlink/lib/libglitz.so 
/pkg/obj/graphics/cairo/work/.buildlink/lib/libpng
12.so /pkg/obj/graphics/cairo/work/.buildlink/lib/libXrender.so -lSM -lICE 
-lX11 -lsocket -lnsl -lm -lc  -Wl,-R/usr/pk
g/lib -Wl,-R/usr/openwin/lib/64
Text relocation remains                         referenced
    against symbol                  offset      in file
_cairo_pixman_image_get_format      0xf89       .libs/cairo-xlib-surface.o
_cairo_pixman_image_get_format      0x4d0       .libs/cairo-glitz-surface.o
_cairo_pixman_image_get_format      0x232e      .libs/cairo-glitz-surface.o
_cairo_pixman_region_create_simple  0xa         
../pixman/src/.libs/libpixman.a(pixregion.o)
_cairo_pixman_region_create_simple  0x2e4       
../pixman/src/.libs/libpixman.a(ictrap.o)
_cairo_pixman_region_create_simple  0x319       
../pixman/src/.libs/libpixman.a(ictrap.o)
_cairo_pixman_region_union          0x1626      
../pixman/src/.libs/libpixman.a(pixregion.o)
_cairo_pixman_region_contains_point 0x6752      
../pixman/src/.libs/libpixman.a(fbcompose.o)
.......
_cairo_pixman_image_create_linear_gradient 0xfbe        .libs/cairo-pattern.o
_cairo_pixman_image_create_radial_gradient 0xfd3        .libs/cairo-pattern.o
ld: fatal: relocations remain against allocatable but non-writable sections
collect2: ld returned 1 exit status
*** Error code 1



>How-To-Repeat:


bmake


>Fix:


visibily attribute hidden is not valid for AMD64 gcc -m64 
need patch for

pixman/src/pixman.h

--- pixman/src/pixman.h.orig    Wed Nov  1 03:27:37 2006
+++ pixman/src/pixman.h Thu Nov 23 10:40:28 2006
@@ -99,7 +99,7 @@
 
 #include "pixman-remap.h"
 
-#if (__GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 3)) && 
defined(__ELF__)
+#if (__GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 3)) && 
defined(__ELF__) && !defined(__sun__)
 #define pixman_private         __attribute__((__visibility__("hidden")))
 #elif defined(__SUNPRO_C) && (__SUNPRO_C >= 0x550)
 #define pixman_private         __hidden