pkg/35258: security/putty fails to build under NetBSD-4 / -current (patch included)

["dhowland%users.sourceforge.net@localhost" <dhowland%users.sourceforge.net@localhost>]

>Number:         35258
>Category:       pkg
>Synopsis:       security/putty fails to build under NetBSD-4 / -current (patch 
>included)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 15 06:50:00 +0000 2006
>Originator:     dhowland%users.sourceforge.net@localhost
>Release:        NetBSD 4.99.5 i386
>Organization:
>Environment:


System: NetBSD 4.99.5 (GENERIC) #1: Wed Dec  6 11:56:19 EST 2006
        root@micron:/usr/4.99/obj/sys/arch/i386/compile/GENERIC



>Description:


security/putty fails to build on systems using gcc4, such as NetBSD-current or 
NetBSD-4.

The problem is gcc4, which complains more than previous versions and this 
package likes to compile with -Werror.



>How-To-Repeat:


cd /usr/pkgsrc/security/putty && make


>Fix:


We could just remove -Werror from the makefile, but I have looked at the 
patches that already exist for this package, and it looks like it is preferred 
to patch the source code to fix the code that generates  the warnings.  Thats 
fine with me.

I have created a set of patches that will address the warnings and allow putty 
to compile fine on my NetBSD-current system.  Four of them are new, one of them 
replaces a current patch (patch-aj).

I will include the patches in a gzipped tarball in a reply to this PR.  If they 
dont come through, just email me, I should provide them qickly.

thanks