pkg/35487: pkgsrc-2006Q4: mkdir used instead of ${MKDIR} in toolchain wrapper script

[mm_lists%pulsar-zone.net@localhost]

>Number:         35487
>Category:       pkg
>Synopsis:       pkgsrc-2006Q4: mkdir used instead of ${MKDIR} in toolchain 
>wrapper script
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 26 17:20:00 +0000 2007
>Originator:     Matthew Mondor
>Release:        3.1_STABLE
>Organization:
Pulsar-Zone
>Environment:
NetBSD hal.xisop 3.1_STABLE NetBSD 3.1_STABLE (GENERIC_MM) #6: Fri Dec 29 
23:55:40 EST 2006  
root%hal.xisop@localhost:/usr/src/sys/arch/i386/compile/GENERIC_MM i386
>Description:
pkgsrc/mk/bsd.wrapper.mk used mkdir instead of ${MKDIR} at one instance,
causing package builds to error.  An example:

===> Creating toolchain wrappers for digest-20060826
mkdir: /usr/pkgsrc/pkgtools/digest/work/.wrapper/tmp: File exists
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/pkgtools/digest
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/pkgtools/digest

The MKDIR wrapper appears to implicitely use -p.  A diff is provided.
>How-To-Repeat:
Attempt to create any package with a recent pkgsrc-2006Q4 on
NetBSD 3.1_STABLE.
>Fix:
cvs diff: Diffing .
Index: bsd.wrapper.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/wrapper/bsd.wrapper.mk,v
retrieving revision 1.60
diff -u -r1.60 bsd.wrapper.mk
--- bsd.wrapper.mk      26 Nov 2006 14:42:17 -0000      1.60
+++ bsd.wrapper.mk      26 Jan 2007 17:11:12 -0000
@@ -571,7 +571,7 @@
 
 .  if !target(${_WRAP_CACHE.${_wrappee_}})
 ${_WRAP_CACHE.${_wrappee_}}:
-       ${RUN} mkdir ${.TARGET:H}
+       ${RUN} ${MKDIR} ${.TARGET:H}
        ${RUN} echo "cachehit=no" > ${.TARGET}
 .  endif