pkg/35583: multimedia/libmp4v2 requires SDL but has no dependency

[kre%munnari.OZ.AU@localhost]

>Number:         35583
>Category:       pkg
>Synopsis:       multimedia/libmp4v2 requires SDL but has no dependency
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 11 09:35:00 +0000 2007
>Originator:     Robert Elz
>Release:        NetBSD 3.99.15  (pkgsrc current within last 12 hours)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 3.99.15 NetBSD 3.99.15 
(GENERIC-1.696-20060125) #8: Wed Jan 25 04:59:39 ICT 2006 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/current/kernels/JADE_ASUS i386
Architecture: i386
Machine: i386
>Description:
        The new multimedia/libmp4v2 package needs devel/SDL installed
        (at build time, no idea about run time), but doesn't have it.

>How-To-Repeat:
        Just try building it without devel/SDl installed.
        I'm using pkg_comp and libkver with NetBSD-3.0 release
        sets (and sources) installed, but I doubt that is even
        slightly relevant.

        Expect to see ...

===> Configuring for libmp4v2-1.5.0.1
=> Checking for portability problems in extracted files
=> Modifying GNU configure scripts to avoid --recheck
=> Replacing config-guess with pkgsrc versions
=> Replacing config-sub with pkgsrc versions
=> Fixing locale directory references.
INFO: [subst.mk:pkglocaledir] Nothing changed in ./Makefile.in.
INFO: [subst.mk:pkglocaledir] Nothing changed in ./common/Makefile.in.
INFO: [subst.mk:pkglocaledir] Nothing changed in ./common/video/Makefile.in.
        [many similar lines deleted]
INFO: [subst.mk:pkglocaledir] Nothing changed in ./util/mpeg2/Makefile.in.
INFO: [subst.mk:pkglocaledir] Nothing changed in ./util/mpeg4vol/Makefile.in.
INFO: [subst.mk:pkglocaledir] Nothing changed in ./util/yuv/Makefile.in.
dir: .
glibtool: not found
sdl-config: not found
SDL does not appear to be installed - install the SDL development package
You must have sdl-config in your path to continue
*** Error code 1
  
Stop. 
make: stopped in /usr/pkgsrc/multimedia/libmp4v2
*** Error code 1



>Fix:
        Apply the following patch ..  (copied from multimedia/mpeg4ip
        which apaprently is where multimedia/libmp4v2 originated).
        With this, it builds (and packages) OK>

--- Makefile.real       2007-02-10 02:57:48.000000000 +0700
+++ Makefile    2007-02-11 16:27:22.000000000 +0700
@@ -20,4 +20,5 @@
 BUILD_DIRS=            lib/mp4v2
 INSTALL_DIRS+=         lib/mp4v2 doc/mp4v2
 
+.include "../../devel/SDL/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"