pkg/35713: devel/scmgit contains a broken patch file (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         35713
>Category:       pkg
>Synopsis:       devel/scmgit contains a broken patch file (+FIX)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 19 16:35:01 +0000 2007
>Originator:     Robert Elz
>Release:        NetBSD 3.99.15  ( pkgsrc current within past 10 hours )
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 3.99.15 NetBSD 3.99.15 
(GENERIC-1.696-20060125) #8: Wed Jan 25 04:59:39 ICT 2006 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/current/kernels/JADE_ASUS i386
Architecture: i386
Machine: i386
>Description:
        The recently added patch-ae for devel/scmgit is missing
        the path component of the filename, causing it to attempt
        (and fail) to patch the top level Makefile instead of the
        Makefile in ther perl subdirectory as intended.

>How-To-Repeat:
        By inspection, of "make patch" in devel/scmgit
        From the latter, expect to see ...

===> Extracting for scmgit-1.5.0 
===> Patching for scmgit-1.5.0
=> Applying pkgsrc patches for scmgit-1.5.0
1 out of 1 hunks failed--saving rejects to Makefile.rej
Patch /usr/pkgsrc/devel/scmgit/patches/patch-ae failed
ERROR: Patching failed due to modified or broken patch file(s):
ERROR:  /usr/pkgsrc/devel/scmgit/patches/patch-ae
*** Error code 1 

>Fix:
        Replace patch-ae with the new version of that patch
        appended below, and "make makepatchsum"

$NetBSD: patch-ae,v 1.1 2007/02/18 22:39:29 rillig Exp $

In pkgsrc, all Perl modules are installed into vendor_perl, not
site_perl.

--- perl/Makefile.orig  2007-02-14 03:46:46.000000000 +0100
+++ perl/Makefile       2007-02-18 23:25:33.000000000 +0100
@@ -7,7 +7,7 @@
 prefix_SQ = $(subst ','\'',$(prefix))
 
 all install instlibdir: $(makfile)
-       $(MAKE) -f $(makfile) $@
+       $(MAKE) -f $(makfile) INSTALLDIRS=vendor $@
 
 clean:
        test -f $(makfile) && $(MAKE) -f $(makfile) $@ || exit 0