pkg/35805: ffmpeg gcc4.1.2 SunOS

["Gilles Dauphin" <dauphin%enst.fr@localhost>]

>Number:         35805
>Category:       pkg
>Synopsis:       ffmpeg gcc4.1.2 SunOS
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 23 09:45:00 +0000 2007
>Originator:     Gilles Dauphin
>Release:        SunOS 5.10 i86pc
>Organization:
ENST 
>Environment:


System: SunOS bi.enst.fr 5.10 Generic_118855-19 i86pc


>Description:


gmake[1]: Entering directory 
`/pkg/obj/multimedia/ffmpeg/work/ffmpeg-0.4.9-pre1/libavcodec'
libtool  --mode=compile gcc -Wall -O -O0 -I/usr/include -DHAVE_AV_CONFIG_H -I.. 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE -c -o common.o 
common.c 
 gcc -Wall -O -O0 -DHAVE_AV_CONFIG_H -I.. -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -D_GNU_SOURCE -c common.c  -fPIC -DPIC -o .libs/common.o
In file included from avcodec.h:14,
                 from common.c:28:
common.h:134: error: static declaration of 'floorf' follows non-static 
declaration




>How-To-Repeat:


bmake


>Fix:


gcc 4.1.2 is really better... 

--- libavcodec/common.h Fri Feb 23 10:38:32 2007
+++ libavcodec/common.h.pkgsrc  Thu Feb 22 18:44:23 2007
@@ -130,13 +130,11 @@
 #    endif
 #endif
 
-#if defined(__GNUC__) && __GNUC__  < 4
 #if defined(CONFIG_OS2) || defined(CONFIG_SUNOS)
 static inline float floorf(float f) { 
     return floor(f); 
 }
 #endif
-#endif
 
 #ifdef CONFIG_WIN32