pkg/35936: gnustep-preferences fails build with -Werror

[oster%netbsd.org@localhost]

>Number:         35936
>Category:       pkg
>Synopsis:       gnustep-preferences fails to build with -Werror
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 06 17:40:00 +0000 2007
>Originator:     oster%netbsd.org@localhost
>Release:        NetBSD 4.0_BETA2
>Organization:
Sometimes.
>Environment:
        
        
System: NetBSD gonzo 4.0_BETA2 NetBSD 4.0_BETA2 (GONZO) #0: Sat Dec  2 15:51:16 
CST 2006  oster@gonzo:/u1/builds/build119/src/sys/arch/i386/compile/GONZO i386
Architecture: i386
Machine: i386
>Description:

Attempt to build gnustep-preferences on a NetBSD 4.0_BETA2 (i386) box with
this gcc:

 Using built-in specs.
 Target: i386--netbsdelf
 Configured with: /usr/src/tools/gcc/../../gnu/dist/gcc4/configure 
--enable-long-long --disable-multilib --enable-threads --disable-symvers 
--build=i386-unknown-netbsdelf4.99.3 --host=i386--netbsdelf 
--target=i386--netbsdelf
 Thread model: posix
 gcc version 4.1.2 20061021 prerelease (NetBSD nb3 20061125)

and watch it go boom:

===> Creating toolchain wrappers for gnustep-preferences-1.2.0nb14
===> Building for gnustep-preferences-1.2.0nb14
Making all in PrefsModule...
gmake[1]: Entering directory 
`/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/Preferences-1.2.0/PrefsModule'
Making build-headers for framework PrefsModule...
/usr/pkg/share/GNUstep/System/Library/Makefiles/Instance/framework.make:72: 
CURRENT_VERSION_NAME is deprecated because it doesnt allow multiple frameworks 
with different versions to be built from warning the same GNUmakefile!  Please 
replace it with XXX_CURRENT_VERSION_NAME
 Creating PrefsModule.framework/Versions/A/Headers...
 Creating derived_src/.stamp...
 Creating PrefsModule.framework/Versions/A/Resources...
Making all for framework PrefsModule...
/usr/pkg/share/GNUstep/System/Library/Makefiles/Instance/framework.make:72: 
CURRENT_VERSION_NAME is deprecated because it doesnt allow multiple frameworks 
with different versions to be built from warning the same GNUmakefile!  Please 
replace it with XXX_CURRENT_VERSION_NAME
 Creating derived_src/NSFramework_PrefsModule.m...
 Compiling file derived_src/NSFramework_PrefsModule.m ...
cc1obj: warnings being treated as errors
derived_src/NSFramework_PrefsModule.m:9: warning: '_OBJC_INSTANCE_0' defined 
but not used
derived_src/NSFramework_PrefsModule.m:11: warning: '_OBJC_INSTANCE_1' defined 
but not used

[wrapper.sh] note: The real command line, after the pkgsrc wrapper, was:
/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/.gcc/bin/gcc 
derived_src/NSFramework_PrefsModule.m -c -MMD -MP 
-I/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/.buildlink/share/GNUstep/Library/Headers
 
-I/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/.buildlink/share/GNUstep/Local/Library/Headers
 
-I/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/.buildlink/share/GNUstep/Network/Library/Headers
 
-I/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/.buildlink/share/GNUstep/System/Library/Headers
 -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 -DGNU_RUNTIME=1 -fPIC 
-DGSWARN -DGSDIAGNOSE -O2 -pipe -Wno-import -fno-strict-aliasing -fgnu-runtime 
-Wall -Wno-import -Werror -fconstant-string-class=NSConstantString 
-I/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/.buildlink/include 
-I./derived_src -I. 
-I/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/fake_home/GNUstep/Library/Headers
 -o shared_obj/NSFramework_PrefsModule.o 
-L/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/.buildlink/lib 
gmake[2]: *** [shared_obj/NSFramework_PrefsModule.o] Error 1
gmake[1]: *** [PrefsModule.all.framework.variables] Error 2
gmake[1]: Leaving directory 
`/usr/pkgsrc/x11/gnustep-preferences/work.gonzo/Preferences-1.2.0/PrefsModule'
gmake: *** [internal-all] Error 2
*** Error code 2

Stop.
make: stopped in /usr/pkgsrc/x11/gnustep-preferences
*** Error code 1


>How-To-Repeat:
        on a i386 box w/ NetBSD 4.0_BETA2:
        cd /usr/pkgsrc/x11/gnustep-preferences
        make package
>Fix:
        nuke the "-Werror" out of all the GNUmakefile.preamble files,
or fix the code so gcc doesn't complain.