Re: PR/35948 CVS commit: pkgsrc/audio/xmms

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

The following reply was made to PR pkg/35948; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/35948 CVS commit: pkgsrc/audio/xmms
Date: Fri, 9 Mar 2007 14:53:18 +0100

 On Fri, Mar 09, 2007 at 01:10:12AM +0000, Roland Illig wrote:
 > The following reply was made to PR pkg/35948; it has been noted by GNATS.
 > 
 > From: Roland Illig <rillig%NetBSD.org@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: PR/35948 CVS commit: pkgsrc/audio/xmms
 > Date: Fri, 09 Mar 2007 02:19:37 +0100
 > 
 >  Joerg Sonnenberger wrote:
 >  >  On Thu, Mar 08, 2007 at 03:05:05PM +0000, Roland Illig wrote:
 >  >  >  Log Message:
 >  >  >  Fixed these gcc error messages from PR 35948:
 >  >  >  
 >  >  >  Sun.c:8: error: static declaration of 'op' follows non-static 
 > declaration
 >  >  >  Sun.h:40: error: previous declaration of 'op' was here
 >  >  
 >  >  Please make / keep it static. The extern is just wrong.
 >  
 >  Have you looked at the other plugins? They all declare the variable as 
 >  extern.
 
 Yes and no. Yes, it is externally visible. No, it shouldn't be. None is
 actually using an explicit extern though.
 
 Joerg