Subject: PR/36387 CVS commit: pkgsrc/mk/flavor/pkg
To: None <joerg@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,>
From: Joerg Sonnenberger <joerg@netbsd.org>
List: pkgsrc-bugs
Date: 05/25/2007 19:10:03
The following reply was made to PR pkg/36387; it has been noted by GNATS.
From: Joerg Sonnenberger <joerg@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/36387 CVS commit: pkgsrc/mk/flavor/pkg
Date: Fri, 25 May 2007 19:07:24 +0000 (UTC)
Module Name: pkgsrc
Committed By: joerg
Date: Fri May 25 19:07:24 UTC 2007
Modified Files:
pkgsrc/mk/flavor/pkg: depends.mk
Removed Files:
pkgsrc/mk/flavor/pkg: install-dependencies
Log Message:
Partly backout the commit and move install-dependencies back into
depends.mk. The quoting of arrays passed down is almost impossible
to get right. For example, PKG_BUILD_OPTION.* variables can contain
multiple space separated entries but have to be quoted twice.
The original commit exposed two separate issues:
- too many variables are passed down via MAKEFLAGS, including the above
mentioned PKG_BUILD_OPTIONs.
- x11/gtk2 used an invalid variable name that can't be assigned
correctly via make command line.
This is supposed to fix PR 36387.
To generate a diff of this commit:
cvs rdiff -r1.31 -r1.32 pkgsrc/mk/flavor/pkg/depends.mk
cvs rdiff -r1.3 -r0 pkgsrc/mk/flavor/pkg/install-dependencies
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.