>Number:         36554
>Category:       pkg
>Synopsis:       Building binary package for security/audit-package fails when MANINSTALL is set to "maninstall"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 25 10:05:00 +0000 2007
>Originator:     Hiroyuki Bessho
>Release:        NetBSD 4.0_BETA2, pkgsrc as of 2007/June/24
>Organization:
>Environment:
System: NetBSD kajiki 4.0_BETA2 NetBSD 4.0_BETA2 (GENERIC.MP) #0: Fri Jun 1 07:24:59 JST 2007 bessho@genete.co.jp:/u00/work/bsh/tnf/4.x/src/sys/arch/amd64/compile/obj.amd64/GENERIC.MP amd64
Architecture: x86_64
Machine: amd64
>Description:
  File check fails during "make package" at security/audit-packages when MANINSTALL=maninstall or MANINSTALL=catinstall.

--- LOG -------------------------------------------------------------
PKG_COMP ==> Entering sandbox `/u0/work/bsh/pkg_comp/noview.current.4.x'
pkg_comp:current.4x.conf# 
pkg_comp:current.4x.conf# 
pkg_comp:current.4x.conf# cd /usr/pkgsrc/security/audit-packages
pkg_comp:current.4x.conf# MANINSTALL=maninstall make package
===> Checking for vulnerabilities in audit-packages-1.46
===> Installing dependencies for audit-packages-1.46
==========================================================================
The following variables will affect the build process of this package,
audit-packages-1.46.  Their current value is shown below:

        * PKGVULNDIR = /usr/pkg/share

You may want to abort the process now with CTRL-C and change their value
before continuing.  Be sure to run `/usr/bin/make clean' after
the changes.
==========================================================================
=> Required installed package digest>=20010302: digest-20060826 found
===> Overriding tools for audit-packages-1.46
===> Extracting for audit-packages-1.46
===> Patching for audit-packages-1.46
===> Creating toolchain wrappers for audit-packages-1.46
===> Configuring for audit-packages-1.46
=> Checking for portability problems in extracted files
===> Building for audit-packages-1.46

[snip]

=> Registering installation for audit-packages-1.46
audit-packages-1.46 requires installed package digest-20060826
=> Checking file-check results for audit-packages-1.46
ERROR: ************************************************************
ERROR: The following files are in /usr/pkg but not in the PLIST:
ERROR:         /usr/pkg/man/cat8/audit-packages.0
ERROR:         /usr/pkg/man/cat8/download-vulnerability-list.0
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/security/audit-packages
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/security/audit-packages
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/security/audit-packages
pkg_comp:current.4x.conf# 
--- End of LOG -------------------------------------------------------------

>How-To-Repeat:
	cd /usr/pkgsrc/security/audit-packages
	MANINSTALL=maninstall make package
>Fix:
  The problem occurs because audit-package package doesn't honor MANINSTALL variable.
  Here's a patch:
Index: Makefile
===================================================================
RCS file: /u00/tnfcvs/pkgsrc/security/audit-packages/Makefile,v
retrieving revision 1.76
diff -u -u -r1.76 Makefile
--- Makefile	14 Jun 2007 08:12:29 -0000	1.76
+++ Makefile	25 Jun 2007 07:12:48 -0000
@@ -72,7 +72,7 @@
 	${NROFF} -man ${WRKSRC}/audit-packages.8 >${WRKSRC}/audit-packages.0
 .endif
 
-do-install:
+do-install: 	realmaninstall
 	${INSTALL_DATA} ${FILESDIR}/audit-packages.conf \
 		${DESTDIR}${PREFIX}/share/examples/audit-packages
 
@@ -80,12 +80,20 @@
 		${INSTALL_SCRIPT} ${WRKSRC}/$$f ${DESTDIR}${PREFIX}/sbin; \
 	done
 
-	${INSTALL_MAN} ${WRKSRC}/audit-packages.0 ${DESTDIR}${CAT8DIR}/
-	${INSTALL_MAN} ${WRKSRC}/audit-packages.8 ${DESTDIR}${MAN8DIR}/
 
+.PHONY: 	catinstall maninstall
+realmaninstall:	${MANINSTALL}
+
+catinstall:
+	${INSTALL_MAN} ${WRKSRC}/audit-packages.0 ${DESTDIR}${CAT8DIR}/
 	${RM} -f ${DESTDIR}${CAT8DIR}/download-vulnerability-list.0
 	${LN} -s audit-packages.0 ${DESTDIR}${CAT8DIR}/download-vulnerability-list.0
+
+maninstall:
+	${INSTALL_MAN} ${WRKSRC}/audit-packages.8 ${DESTDIR}${MAN8DIR}/
+
 	${RM} -f ${DESTDIR}${MAN8DIR}/download-vulnerability-list.8
 	${LN} -s audit-packages.8 ${DESTDIR}${MAN8DIR}/download-vulnerability-list.8
 
+
 .include "../../mk/bsd.pkg.mk"