pkg/36810: xfreecell in pkgsrc 2007Q2 fails to build due to errors

[mphuff%gmail.com@localhost]

>Number:         36810
>Category:       pkg
>Synopsis:       xfreecell in pkgsrc 2007Q2 fails to build due to errors
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 21 07:25:01 +0000 2007
>Originator:     Michael Huff
>Release:        n/a
>Organization:
n/a
>Environment:
SunOS vorenus 5.11 snv_55b i86pc i386 i86pc

>Description:
Trying to build games/xfreecell on an opensolaris box (b_55) fails with an  
error about not being able to open an include file ("gnmanager.h", line 6: 
Error: Could not open include file<hash_set>.). 

I am using the default version of g++:
$g++ -v   
Reading specs from /usr/sfw/lib/gcc/i386-pc-solaris2.11/3.4.3/specs
Configured with: /builds1/sfwnv-gate/usr/src/cmd/gcc/gcc-3.4.3/configure 
--prefix=/usr/sfw --with-as=/usr/sfw/bin/gas --with-gnu-as 
--with-ld=/usr/ccs/bin/ld --without-gnu-ld --enable-languages=c,c++,f77 
--enable-shared
Thread model: posix
gcc version 3.4.3 (csl-sol210-3_4-20050802)

Here is the output from running 'bmake package':
$sudo bmake package
=> Required installed package digest>=20010302: digest-20060826 found
===> Skipping vulnerability checks.
WARNING: No /pkgsrc/distfiles/pkg-vulnerabilities file found.
WARNING: To fix, install the pkgsrc/security/audit-packages
WARNING: package and run: ``/usr/pkg/sbin/download-vulnerability-list''.
=> Fetching xfreecell-1.0.5b.tgz
=> Checksum SHA1 OK for xfreecell-1.0.5b.tgz
=> Checksum RMD160 OK for xfreecell-1.0.5b.tgz
===> Installing dependencies for xfreecell-1.0.5bnb1
=> Required installed package xpkgwedge>=1.15: xpkgwedge-1.16 found
=> Required installed package gmake>=3.78: gmake-3.81 found
=> Required installed package x11-links>=0.25: x11-links-0.31 found
=> Required installed package xextproto>=7.0: xextproto-7.0.2 found
=> Required installed package inputproto>=1.4: inputproto-1.4.1 found
===> Overriding tools for xfreecell-1.0.5bnb1
===> Extracting for xfreecell-1.0.5bnb1
===> Patching for xfreecell-1.0.5bnb1
=> Applying pkgsrc patches for xfreecell-1.0.5bnb1
===> Creating toolchain wrappers for xfreecell-1.0.5bnb1
===> Building for xfreecell-1.0.5bnb1
g++ -c -Wall -DSHAPE -DBOGUSRANDOM -I/usr/openwin/include card.cpp
"widget/widget.h", line 200: Warning: NSLabel::label hides the function 
NSString::label() const.
"widget/widget.h", line 239: Warning: NSButton::width hides the virtual 
function NSWindow::width() const.
"widget/widget.h", line 239: Warning: NSButton::height hides the virtual 
function NSWindow::height() const.
"widget/widget.h", line 239: Warning: NSButton::label hides the function 
NSString::label() const.
"widget/widget.h", line 239: Warning: NSButton::redraw hides the function 
NSPlate::redraw(NSPlate::Mode).
"widget/widget.h", line 347: Warning: NSHContainer::width hides the virtual 
function NSContainer::width() const.
"widget/widget.h", line 347: Warning: NSHContainer::height hides the virtual 
function NSContainer::height() const.
"widget/widget.h", line 361: Warning: NSVContainer::width hides the virtual 
function NSContainer::width() const.
"widget/widget.h", line 361: Warning: NSVContainer::height hides the virtual 
function NSContainer::height() const.
"widget/widget.h", line 395: Warning: NSFrame::map hides the virtual function 
NSWindow::map() const.
"widget/widget.h", line 442: Warning: NSVScrollbar::map hides the virtual 
function NSWindow::map() const.
"widget/widget.h", line 480: Warning: NSHScrollbar::map hides the virtual 
function NSWindow::map() const.
"card.h", line 47: Warning: Card::move hides the virtual function 
NSWindow::move(int, int).
"card.h", line 47: Warning: Card::parent hides the virtual function 
NSWindow::parent(unsigned long).
"card.h", line 47: Warning: Card::parent hides the virtual function 
NSWindow::parent(NSWindow&).
15 Warning(s) detected.
g++ -c -Wall -DSHAPE -DBOGUSRANDOM -I/usr/openwin/include freecell.cpp
"widget/widget.h", line 200: Warning: NSLabel::label hides the function 
NSString::label() const.
"widget/widget.h", line 239: Warning: NSButton::width hides the virtual 
function NSWindow::width() const.
"widget/widget.h", line 239: Warning: NSButton::height hides the virtual 
function NSWindow::height() const.
"widget/widget.h", line 239: Warning: NSButton::label hides the function 
NSString::label() const.
"widget/widget.h", line 239: Warning: NSButton::redraw hides the function 
NSPlate::redraw(NSPlate::Mode).
"widget/widget.h", line 347: Warning: NSHContainer::width hides the virtual 
function NSContainer::width() const.
"widget/widget.h", line 347: Warning: NSHContainer::height hides the virtual 
function NSContainer::height() const.
"widget/widget.h", line 361: Warning: NSVContainer::width hides the virtual 
function NSContainer::width() const.
"widget/widget.h", line 361: Warning: NSVContainer::height hides the virtual 
function NSContainer::height() const.
"widget/widget.h", line 395: Warning: NSFrame::map hides the virtual function 
NSWindow::map() const.
"widget/widget.h", line 442: Warning: NSVScrollbar::map hides the virtual 
function NSWindow::map() const.
"widget/widget.h", line 480: Warning: NSHScrollbar::map hides the virtual 
function NSWindow::map() const.
"card.h", line 47: Warning: Card::move hides the virtual function 
NSWindow::move(int, int).
"card.h", line 47: Warning: Card::parent hides the virtual function 
NSWindow::parent(unsigned long).
"card.h", line 47: Warning: Card::parent hides the virtual function 
NSWindow::parent(NSWindow&).
"gnmanager.h", line 6: Error: Could not open include file<hash_set>.
"gnmanager.h", line 29: Warning (Anachronism): Using hash_set as a template 
without a declaration.
"gnmanager.h", line 29: Error: A class template name was expected instead of 
hash_set.
"gnmanager.h", line 30: Warning (Anachronism): Using hash_set as a template 
without a declaration.
"gnmanager.h", line 30: Error: A class template name was expected instead of 
hash_set.
"gnmanager.h", line 34: Error: A class template name was expected instead of 
hash_set.
"gnmanager.h", line 35: Error: A class template name was expected instead of 
hash_set.
"gnmanager.h", line 39: Error: A class template name was expected instead of 
hash_set.
"gnmanager.h", line 40: Error: A class template name was expected instead of 
hash_set.
"freecell.cpp", line 66: Warning: Empty declaration (probably an extra 
semicolon).
"freecell.cpp", line 229: Warning: statement is unreachable.
"freecell.cpp", line 232: Warning: "adjustSubwindow(NSWindow*)" has been called 
before being declared inline.
"freecell.cpp", line 240: Warning: "gameWon()" has been called before being 
declared inline.
"freecell.cpp", line 246: Warning: gameNumber hides the same name in an outer 
scope.
"freecell.cpp", line 276: Warning: gameNumber hides the same name in an outer 
scope.
"freecell.cpp", line 311: Warning: gameNumber hides the same name in an outer 
scope.
"freecell.cpp", line 330: Warning: Club hides the same name in an outer scope.
"freecell.cpp", line 331: Warning: Diamond hides the same name in an outer 
scope.
"freecell.cpp", line 332: Warning: Heart hides the same name in an outer scope.
"freecell.cpp", line 333: Warning: Spade hides the same name in an outer scope.
"freecell.cpp", line 353: Warning: gameNumber hides the same name in an outer 
scope.
"freecell.cpp", line 562: Warning: "beginNewGame(int)" has been called before 
being declared inline.
"freecell.cpp", line 562: Warning: gameNumber hides the same name in an outer 
scope.
"freecell.cpp", line 627: Warning: statement is unreachable.
7 Error(s) and 32 Warning(s) detected.
gmake: *** [freecell.o] Error 7
*** Error code 2

Stop.
bmake: stopped in /pkgsrc/games/xfreecell
*** Error code 1

Stop.
bmake: stopped in /pkgsrc/games/xfreecell

>How-To-Repeat:
cd games/xfreecell;sudo bmake package
>Fix: