pkg/36823: www/seamonkey-bin Makefile.common syntax unsuitable for NetBSD 3

[kre%munnari.OZ.AU@localhost]

>Number:         36823
>Category:       pkg
>Synopsis:       www/seamonkey-bin Makefile.common syntax unsuitable for NetBSD 
>3
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 23 03:25:00 +0000 2007
>Originator:     Robert Elz
>Release:        NetBSD 3.99.15  (-- pkgsrc current within past 6 hours)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 3.99.15 NetBSD 3.99.15 
(GENERIC-1.696-20060125) #8: Wed Jan 25 04:59:39 ICT 2006 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/current/kernels/JADE_ASUS i386
Architecture: i386
Machine: i386
>Description:
        various of the bin-nightly mozilla derived packages
        (thunderbird, seamonkey, forefox) generate messages like ...

/usr/pkgsrc/www/firefox-bin-nightly/Makefile: make: 
"../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/Makefile.common"
 line 32: Malformed conditional (!empty(EMUL_DISTRO:Mnative-*)) make: 
"../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/Makefile.common"
 line 38: if-less endif make: 
"../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/Makefile.common"
 line 38: Need an operator make: 
"../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/Makefile.common"
 line 101: Malformed conditional (!empty(EMUL_DISTRO:Mnative-*)) make: 
"../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/Makefile.common"
 line 136: if-less endif make: 
"../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/!
 ../../www/seamonkey-bin-nightly/../../www/seamonkey-bin/Makefile.common" line 
136: Need an operator make: Fatal errors encountered -- cannot continue

        with the version of www/seamonkey-bin/Makefile.common that
        they all use (when used on a NetBSD 3 system, I suspect the
        syntax of make on current has been extended...)

>How-To-Repeat:
        Do just about anything with one of those packages and observe...

>Fix:
        Applying the appended patch to ww/seamonkey-bin/Makefile.common
        cures the syntax errors.

        BEWARE: I have not analysed the intent of what is happening with
        any of this stuff, my patch might not implement the intended
        semantics.   I don't use any of the affected packages, I just want
        the noise gone from my output from stuff like lintpkgsrc -p
        (which is where I detected the problem).   So, please check before
        applying the patch to see that it does what it should be doing.

Index: Makefile.common
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/www/seamonkey-bin/Makefile.common,v
retrieving revision 1.5
diff -u -r1.5 Makefile.common
--- Makefile.common     6 Aug 2007 08:51:40 -0000       1.5
+++ Makefile.common     23 Aug 2007 03:19:18 -0000
@@ -29,7 +29,7 @@
 SUSE_VERSION_REQD=     7.3
 .endif
 
-.if !empty(EMUL_DISTRO:Mnative-*)
+.if defined(EMUL_DISTRO) && !empty(EMUL_DISTRO:Mnative-*)
 .  if defined(MOZ_GTK2) && !empty(MOZ_GTK2:M[Yy][Ee][Ss])
 DEPENDS+=              gtk2+>=2.2:../../x11/gtk2
 .  else
@@ -98,7 +98,7 @@
 # builds typically want exactly 'libgtk-1.2.so.0', etc. symlink them
 # into the mozilla directory.
 post-install:
-.if !empty(EMUL_DISTRO:Mnative-*)
+.if defined(EMUL_DISTRO) && !empty(EMUL_DISTRO:Mnative-*)
 .  if defined(MOZ_GTK2) && !empty(MOZ_GTK2:M[Yy][Ee][Ss])
        @cd ${MOZILLA_LIB} && \
        ${LN} -s ${PREFIX}/lib/libatk-1.0.*so* .;                       \