pkg/36895: editors/nvi: option for enabling widechar support.

[lems%gmx.net@localhost]

>Number:         36895
>Category:       pkg
>Synopsis:       editors/nvi: option for enabling widechar support.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 04 09:20:00 +0000 2007
>Originator:     L. Schmidt
>Release:        
>Organization:
>Environment:
Linux unruhe 2.6.20-16-generic #2 SMP Fri Aug 31 00:55:27 UTC 2007 i686 
GNU/Linux
>Description:
Hello,

the version of nvi in pkgsrc has widechar support (--enable-widechar)
I added an option.mk file that provides an option for building it
against ncursesw.
The options.mk file needs reviewing, since I haven't worked with
pkgsrc for a while and think there's still something missing; e.g., do I
need to include converters/libiconv/buildlink3.mk, too?
It should not definitely not be enabled by default, as there are some
bugs when build with widechar support [1] -- a note---at least in
options.mk---could be added, if necessary.

I have attached a small patch for .../nvi/Makefile and the options.mk
file.

Regards

Leonard

[1] http://opal.com/freebsd/unicode.html#nvi

p. s. This was first meant to be send to tech-pkg@, but a problem report       
may be better.
>How-To-Repeat:

>Fix:
options.mk:

# $NetBSD$

PKG_OPTIONS_VAR=        PKG_OPTIONS.nvi
PKG_SUPPORTED_OPTIONS=  ncursesw
#PKG_SUGGESTED_OPTIONS= ncursesw

.include "../../mk/bsd.options.mk"

.if !empty(PKG_OPTIONS:Mncursesw)
.  include "../../devel/ncursesw/buildlink3.mk"
CONFIGURE_ARGS+=        --enable-widechar
#CONFIGURE_ARGS+=       --with-curses=${BUILDLINK_PREFIX.ncursesw}
.else
.  include "../../mk/curses.buildlink3.mk"
.endif


Makefile-enable-widechar-support.diff:

$NetBSD$

--- Makefile.orig       2007-09-03 22:34:12.000000000 +0200
+++ Makefile
@@ -11,6 +11,8 @@ MAINTAINER=   pkgsrc-users%NetBSD.org@localhost
 HOMEPAGE=      http://www.kotnet.org/~skimo/nvi/devel/
 COMMENT=       Berkeley nvi with additional features
 
+.include "options.mk"
+
 .include "../../mk/bsd.prefs.mk"
 
 .if ${OPSYS} == "NetBSD"
@@ -37,5 +39,4 @@ USE_TOOLS+=           sh
 USE_LIBTOOL=           YES
 
 .include "../../databases/db3/buildlink3.mk"
-.include "../../mk/curses.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"