Re: pkg/36943: net/ttt fails to build with gcc4 (please update to 1.8.2)

[Yakovetsky Vladimir <yx%x.ua@localhost>]

On Fri, Sep 07, 2007 at 12:45:02PM +0000, OBATA Akio wrote:
>  
>>> Description:
>>      net/ttt fails to build with gcc4
>>      (writable-strings support is excluded)
> (snip)
>>> Fix:
>>      update to 1.8.2:
>  
> Version 1.8.2 isn't announced on HOMEPAGE.  Is it really stable version?
>
  Sorry, I not absolutely understand stablity in the given context, but
  ttt from 1.8.2build works for me (i.e. ttt is started and shows graphs).


> And are there any changes since 1.8.1 other than fix of this problem?
>  
  diff shows distinctions only in configure.in and net_names.c files:

--- ttt-1.8.1/configure.in
+++ ttt-1.8.2/configure.in
@@ -115,7 +115,7 @@
 fi
 
 if test "${tttHaveGcc}" = "yes" ; then
-  GCCFLAGS="-Wall -Wwrite-strings -fwritable-strings"
+  GCCFLAGS="-Wall"
 else 
   GCCFLAGS=""
 fi-- ttt-1.8.1/configure.in    2003-10-16 19:09:27.000000000 +0300
+++ ttt-1.8.2/configure.in      2004-08-14 15:25:00.000000000 +0300
@@ -115,7 +115,7 @@
 fi
 
 if test "${tttHaveGcc}" = "yes" ; then
-  GCCFLAGS="-Wall -Wwrite-strings -fwritable-strings"
+  GCCFLAGS="-Wall"
 else 
   GCCFLAGS=""
 fi

--- ttt-1.8.1/net_names.c
+++ ttt-1.8.2/net_names.c
@@ -1,4 +1,4 @@
-/* $Id: net_names.c,v 0.8 2003/10/16 11:55:00 kjc Exp $ */
+/* $Id: net_names.c,v 0.10 2004/08/14 12:32:13 kjc Exp kjc $ */
 /*
  *  Copyright (c) 1996-2000
  *     Sony Computer Science Laboratories, Inc.  All rights reserved.
@@ -16,6 +16,7 @@
 /* net_names.c -- a module to translate ids to name strings.  */
 #include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
 #include <sys/param.h>
 #include <sys/time.h>
 #include <sys/types.h>
@@ -259,9 +260,9 @@
        break;
     case TTTTYPE_IPV6HOST:
     {
-       u_long tmp[4];
-       static char *inet6_ntoa(u_long *addr);  /* should be replaced
-                                                  by addr2ascii */
+       u_int32_t tmp[4];
+       static char *inet6_ntoa(u_int32_t *addr);  /* should be replaced
+                                                     by addr2ascii */
        if ((buf = malloc(sizeof("xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx")))
            == NULL)
            fatal_error("get_protoname: no memory\n");



-- 
Yakovetsky Vladimir