Re: pkg/36983: news/tin: add ncurses and ncursesw options

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR pkg/36983; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: lems%gmx.net@localhost
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: pkg/36983: news/tin: add ncurses and ncursesw options
Date: Thu, 13 Sep 2007 23:03:12 +0200

 --i7F3eY7HS/tUJxUd
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Thu, Sep 13, 2007 at 11:40:01AM +0000, lems%gmx.net@localhost wrote:
 > >Number:         36983
 > >Category:       pkg
 > >Synopsis:       news/tin: add ncurses and ncursesw options
 
 I modified your patch to use option groups, which solves the problem
 you mention.
 
 However, on NetBSD-4.99.31/amd64 with the ncursesw option, configuring
 fails with:
 
 configure:6838: cc -c -O2 -I/usr/pkg/include -I/usr/include -I/usr/pkg/include 
-
 I/usr/pkg/include/ncursesw -I/usr/pkg/include -I/usr/include conftest.c 1>&5
 configure: In function 'main':
 configure:6822: error: 'make' undeclared (first use in this function)
 configure:6822: error: (Each undeclared identifier is reported only once
 configure:6822: error: for each function it appears in.)
 configure:6822: error: expected ';' before 'an'
 configure: failed program was:
 #line 6809 "configure"
 #include "confdefs.h"
 
 
 #define _XOPEN_SOURCE_EXTENDED
 #undef  HAVE_LIBUTF8_H  /* in case we used CF_UTF8_LIB */
 #define HAVE_LIBUTF8_H  /* to force ncurses' header file to use cchar_t */
 
 #include <curses.h>
 int main() {
 #ifdef NCURSES_VERSION
 
 #ifndef WACS_BSSB
         make an error
 #endif
 
 printf("%s\n", NCURSES_VERSION);
 #else
 #ifdef __NCURSES_H
 printf("old\n");
 #else
         make an error
 #endif
 #endif
 
 
 ; return 0; }
 
 I guess it pulls in the NetBSD curses.h instead of the ncurses one.
 Where did you test this and why did it work for you?
  Thomas
 
 --i7F3eY7HS/tUJxUd
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="tin.diff"
 
 Index: options.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/news/tin/options.mk,v
 retrieving revision 1.6
 diff -u -r1.6 options.mk
 --- options.mk 30 Jan 2007 07:11:46 -0000      1.6
 +++ options.mk 13 Sep 2007 21:00:21 -0000
 @@ -1,16 +1,31 @@
  # $NetBSD: options.mk,v 1.6 2007/01/30 07:11:46 wiz Exp $
  
 -.include "../../mk/bsd.prefs.mk"
 -
 -PKG_OPTIONS_VAR=      PKG_OPTIONS.tin
 -PKG_SUPPORTED_OPTIONS=        curses icu inet6 tin-use-inn-spool
 +PKG_OPTIONS_VAR=              PKG_OPTIONS.tin
 +PKG_SUPPORTED_OPTIONS=                icu inet6 tin-use-inn-spool
 +PKG_OPTIONS_REQUIRED_GROUPS=  display
 +PKG_OPTIONS_GROUP.display=    curses ncurses ncursesw
 +PKG_SUGGESTED_OPTIONS=                curses
  # untested
  #PKG_SUPPORTED_OPTIONS+=      socks
  
  .include "../../mk/bsd.options.mk"
  
  .if !empty(PKG_OPTIONS:Mcurses)
 +.  include "../../mk/curses.buildlink3.mk"
  CONFIGURE_ARGS+=      --with-screen=curses
 +CONFIGURE_ARGS+=      --with-curses-dir=${BUILDLINK_PREFIX.curses}
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Mncurses)
 +.  include "../../devel/ncurses/buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-screen=ncurses
 +CONFIGURE_ARGS+=      --with-curses-dir=${BUILDLINK_PREFIX.ncurses}
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Mncursesw)
 +.  include "../../devel/ncursesw/buildlink3.mk"
 +CONFIGURE_ARGS+=      --with-screen=ncursesw
 +CONFIGURE_ARGS+=      --with-curses-dir=${BUILDLINK_PREFIX.ncursesw}
  .endif
  
  .if !empty(PKG_OPTIONS:Micu)
 
 --i7F3eY7HS/tUJxUd--