Re: pkg/31417: gdm syslogs username

[Hauke Fath <hf%spg.tu-darmstadt.de@localhost>]

The following reply was made to PR pkg/31417; it has been noted by GNATS.

From: Hauke Fath <hf%spg.tu-darmstadt.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost
Subject: Re: pkg/31417: gdm syslogs username
Date: Tue, 09 Oct 2007 18:20:59 +0200

 This is a multi-part message in MIME format.
 --------------090203040302030005020508
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 8bit
 
 Hauke Fath wrote:
 >  I think I can come up with patches that at least avoid logging the 
 >  user name, until the (hopefully) fixed upstream version trickles down 
 >  to pkgsrc.
 
 Patches attached. They bring the logging behaviour of 
 verify-{shadow,crypt}.c in line with what verify-pam.c does.
 
        hauke
 
 -- 
       The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email            Institut für Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
       Respect for open standards              Ruf +49-6151-16-3281
 
 --------------090203040302030005020508
 Content-Type: text/plain;
  name="distinfo.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="distinfo.diff"
 
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/x11/gdm/distinfo,v
 retrieving revision 1.50
 diff -u -u -r1.50 distinfo
 --- distinfo   9 Aug 2007 19:39:16 -0000       1.50
 +++ distinfo   9 Oct 2007 16:15:41 -0000
 @@ -9,3 +9,5 @@
  SHA1 (patch-ae) = c95265b55c968a0466e1ae50bbe58c121f05b027
  SHA1 (patch-ak) = e3eaf2dfa1e393f9808d22fe4384710a46a83afc
  SHA1 (patch-al) = 3b66dd3f4cdea6a3af5cbd0ff65eb02ccdead483
 +SHA1 (patch-am) = fe4692eb38c97c23499520eb72e24de21ed130af
 +SHA1 (patch-an) = ff74bf74e6047a28252c9d043925fbdf1d3556e9
 
 --------------090203040302030005020508
 Content-Type: text/plain;
  name="patch-am"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="patch-am"
 
 $NetBSD$
 
 --- daemon/verify-crypt.c.orig 2007-07-30 22:06:56.000000000 +0200
 +++ daemon/verify-crypt.c
 @@ -178,7 +178,7 @@ authenticate_again:
  
      if (pwent == NULL) {
            gdm_sleep_no_signal (gdm_get_value_int (GDM_KEY_RETRY_DELAY));
 -          gdm_error (_("Couldn't authenticate user \"%s\""), login);
 +          gdm_error (_("Couldn't authenticate user"));
  
            print_cant_auth_errbox ();
  
 @@ -192,7 +192,7 @@ authenticate_again:
      if (ppasswd == NULL || (ppasswd[0] != '\0' &&
                            strcmp (crypt (passwd, ppasswd), ppasswd) != 0)) {
            gdm_sleep_no_signal (gdm_get_value_int (GDM_KEY_RETRY_DELAY));
 -          gdm_error (_("Couldn't authenticate user \"%s\""), login);
 +          gdm_error (_("Couldn't authenticate user"));
  
            print_cant_auth_errbox ();
  
 
 --------------090203040302030005020508
 Content-Type: text/plain;
  name="patch-an"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="patch-an"
 
 $NetBSD$
 
 --- daemon/verify-shadow.c.orig        2007-07-30 22:06:56.000000000 +0200
 +++ daemon/verify-shadow.c
 @@ -199,7 +199,7 @@ authenticate_again:
  
      if (pwent == NULL) {
            gdm_sleep_no_signal (gdm_get_value_int (GDM_KEY_RETRY_DELAY));
 -          gdm_error (_("Couldn't authenticate user \"%s\""), login);
 +          gdm_error (_("Couldn't authenticate user"));
  
            print_cant_auth_errbox ();
  
 @@ -213,7 +213,7 @@ authenticate_again:
      if (ppasswd == NULL || (ppasswd[0] != '\0' &&
                            strcmp (crypt (passwd, ppasswd), ppasswd) != 0)) {
            gdm_sleep_no_signal (gdm_get_value_int (GDM_KEY_RETRY_DELAY));
 -          gdm_error (_("Couldn't authenticate user \"%s\""), login);
 +          gdm_error (_("Couldn't authenticate user"));
  
            print_cant_auth_errbox ();
  
 
 --------------090203040302030005020508--