pkg/37136: pine upgrade weirdness

[martti.kuparinen%iki.fi@localhost]

>Number:         37136
>Category:       pkg
>Synopsis:       pine upgrade weirdness
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 16 06:25:00 +0000 2007
>Originator:     Martti Kuparinen
>Release:        NetBSD 4.0_RC2
>Organization:
>Environment:
System: NetBSD p130.mydomain.com 4.0_RC2 NetBSD 4.0_RC2 (P130) #3: Mon Oct 1 
09:13:42 EEST 2007 
root%p130.mydomain.com@localhost:/usr/src/sys/arch/amd64/compile/P130 amd64
Architecture: x86_64
Machine: amd64
>Description:

Currently the pine package upgrade does not work correctly (this has been
the case for long time and now I got tired of it so here's a PR).

Initial installation is okay but upgrading the pine package puts local
customizations (if they exist) to the global example file. IMO this
is wrong and I've not seen this with other packages.

>How-To-Repeat:

#
# Get the latest pkgsrc
#
cd /usr/pkgsrc
cvs update -dPA

#
# Install pine and customize the global configuration file. Make copies
# of the files for later comparison.
#
cd /usr/pkgsrc/mail/pine
make update
vi /usr/pkg/etc/pine.conf
cp /usr/pkg/share/examples/pine/pine.conf /tmp/1
cp /usr/pkg/etc/pine.conf /tmp/2

#
# Now update pine (to the same version in this case) and notice how
# /usr/pkg/share/examples/pine/pine.conf contains the local changes
# made to /usr/pkg/etc/pine.conf
#
cd /usr/pkgsrc/mail/pine
make update
diff -q /tmp/1 /usr/pkg/share/examples/pine/pine.conf
Files /tmp/1 and /usr/pkg/share/examples/pine/pine.conf differ

#
# The customized file is left untouched as it should be
#
diff -q /tmp/2 /usr/pkg/etc/pine.conf

#
# Currently the only way to upgrade pine is to remove /usr/pkg/etc/pine.conf
# before performing the upgrade and finally re-customize the pine.conf
#
rm -f /usr/pkg/etc/pine.conf
make update

>Fix: