pkg/37148: _CHECKSUM_CMD not defined if NO_CHECKSUM="yes"

[lacombar%gmail.com@localhost]

>Number:         37148
>Category:       pkg
>Synopsis:       _CHECKSUM_CMD not defined if NO_CHECKSUM="yes"
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 18 23:35:00 +0000 2007
>Originator:     Arnaud Lacombe
>Release:        -current
>Organization:
>Environment:
4.99.32
>Description:
if NO_CHECKSUM="yes" is defined in Makefile and that patch exists, the call to 
${_CHECKSUM_CMD} in `../patch/patch.mk:300` will result in:
-p: command not found
>How-To-Repeat:
try to install pkg which defines NO_CHECKSUM and have patch
>Fix:
define _CHECKSUM_CMD whether or not NO_CHECKSUM is defined:

cvs diff: Diffing .
Index: bsd.checksum-vars.mk
===================================================================
RCS file: /data/netbsd/cvsroot/pkgsrc/mk/checksum/bsd.checksum-vars.mk,v
retrieving revision 1.1
diff -u -r1.1 bsd.checksum-vars.mk
--- bsd.checksum-vars.mk        13 Jul 2006 14:02:34 -0000      1.1
+++ bsd.checksum-vars.mk        18 Oct 2007 22:31:11 -0000
@@ -10,3 +10,10 @@
 #
 
 DISTINFO_FILE?=                ${PKGDIR}/distinfo+
+_CHECKSUM_CMD=                                                        \
+       ${SETENV} DIGEST=${TOOLS_DIGEST:Q} CAT=${TOOLS_CAT:Q}          \
+               ECHO=${TOOLS_ECHO:Q} SED=${TOOLS_SED:Q}                \
+               TEST=${TOOLS_TEST:Q}                                   \
+       ${SH} ${PKGSRCDIR}/mk/checksum/checksum                        \
+
Index: checksum.mk
===================================================================
RCS file: /data/netbsd/cvsroot/pkgsrc/mk/checksum/checksum.mk,v
retrieving revision 1.12
diff -u -r1.12 checksum.mk
--- checksum.mk 9 Oct 2007 19:19:13 -0000       1.12
+++ checksum.mk 18 Oct 2007 22:28:31 -0000
@@ -26,12 +26,6 @@
 #
 _COOKIE.checksum=      ${_COOKIE.extract}
 
-_CHECKSUM_CMD=                                                        \
-       ${SETENV} DIGEST=${TOOLS_DIGEST:Q} CAT=${TOOLS_CAT:Q}          \
-               ECHO=${TOOLS_ECHO:Q} SED=${TOOLS_SED:Q}                \
-               TEST=${TOOLS_TEST:Q}                                   \
-       ${SH} ${PKGSRCDIR}/mk/checksum/checksum                        \
- 
checksum checksum-phase:
        ${RUN} set -e;                                                 \
        case ${.TARGET:Q} in                                           \