pkg/37173: PKG_OPTIONS.tin and curses

[dholland%eecs.harvard.edu@localhost]

>Number:         37173
>Category:       pkg
>Synopsis:       PKG_OPTIONS.tin and curses
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 22 20:35:00 +0000 2007
>Originator:     David A. Holland <dholland%eecs.harvard.edu@localhost>
>Release:        NetBSD 2.1.0_STABLE (20070915) (current pkgsrc)
>Organization:
   EECS
>Environment:
System: NetBSD bantha 2.1.0_STABLE NetBSD 2.1.0_STABLE (GENERIC) #3: Fri Dec  1 
14:58:15 EST 2006  root@bantha:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:

Recently the PKG_OPTIONS for tin were rearranged to allow choosing
curses, ncurses, or ncursesw. None of these, however, is the same as
the behavior prior to the rearrangement; the choice apparently has
broad user-visible implications, and consequently the users complained.

>How-To-Repeat:

Recompile tin with the default PKG_OPTIONS. The reports I got included
changes in color display and arrow key behavior, and maybe other stuff.

>Fix:

This adds an option to select the old behavior. It might be best to
make it the default as well, so as to create the least surprise.

Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/news/tin/options.mk,v
retrieving revision 1.8
diff -u -r1.8 options.mk
--- options.mk  19 Sep 2007 05:55:05 -0000      1.8
+++ options.mk  22 Oct 2007 19:11:55 -0000
@@ -3,7 +3,7 @@
 PKG_OPTIONS_VAR=               PKG_OPTIONS.tin
 PKG_SUPPORTED_OPTIONS=         icu inet6 tin-use-inn-spool
 PKG_OPTIONS_REQUIRED_GROUPS=   display
-PKG_OPTIONS_GROUP.display=     curses ncurses ncursesw
+PKG_OPTIONS_GROUP.display=     nocurses curses ncurses ncursesw
 PKG_SUGGESTED_OPTIONS=         curses
 # untested
 #PKG_SUPPORTED_OPTIONS+=       socks