Subject: Re: pkg/37447: pkg_create failure in bulk build leaves truncated
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Joerg Sonnenberger <joerg@britannica.bec.de>
List: pkgsrc-bugs
Date: 11/30/2007 10:55:03
The following reply was made to PR pkg/37447; it has been noted by GNATS.
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/37447: pkg_create failure in bulk build leaves truncated
.tgz file
Date: Fri, 30 Nov 2007 11:50:26 +0100
On Thu, Nov 29, 2007 at 05:50:02PM +0000, Roland Illig wrote:
> The following reply was made to PR pkg/37447; it has been noted by GNATS.
>
> From: Roland Illig <rillig@NetBSD.org>
> To: gnats-bugs@NetBSD.org
> Cc:
> Subject: Re: pkg/37447: pkg_create failure in bulk build leaves truncated
> .tgz file
> Date: Thu, 29 Nov 2007 18:47:18 +0100
>
> Joerg Sonnenberger wrote:
> > On Thu, Nov 29, 2007 at 11:00:01AM +0000, Andreas Gustafsson wrote:
> > > Make pkg_create unlink the package .tgz file on failure.
> >
> > I don't think it should do that.
>
> I think it should. Having a broken file is worse than having no file at all.
>
> Why don't you think it should do that?
Because the package is as broken as the installed version currently is.
I have no problem with the package target removing the file on error,
but it shouldn't be the job of pkg_create.
Joerg