Subject: Re: pkg/37497: glib2 patches for solaris 10/suncc
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-bugs
Date: 12/08/2007 03:35:02
The following reply was made to PR pkg/37497; it has been noted by GNATS.
From: Roland Illig <rillig@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/37497: glib2 patches for solaris 10/suncc
Date: Sat, 08 Dec 2007 04:34:43 +0100
heas@shrubbery.net wrote:
> Index: patches/patch-aj
> ===================================================================
> RCS file: /cvsroot/pkgsrc/devel/glib2/patches/patch-aj,v
> retrieving revision 1.4
> diff -u -r1.4 patch-aj
> --- patches/patch-aj 24 Mar 2007 20:58:20 -0000 1.4
> +++ patches/patch-aj 7 Dec 2007 19:05:04 -0000
> ---- glib/giounix.c.orig 2007-01-30 02:23:28.238812000 +1300
> +--- glib/giounix.c.orig 2007-11-24 06:40:59.000000000 +0000
> +++ glib/giounix.c
> -@@ -33,6 +33,7 @@
> +@@ -33,7 +33,9 @@
>
> #include "config.h"
>
> +#define _XOPEN_SOURCE 600
> #define _POSIX_SOURCE /* for SSIZE_MAX */
> ++#define _STDC_C99
I won't accept this patch, since /usr/include/sys/feature_tests.h says:
* The feature test macros __XOPEN_OR_POSIX, _STRICT_STDC, and _STDC_C99
* are Sun implementation specific macros created in order to compress
* common standards specified feature test macros for easier reading.
* These macros should not be used by the application developer as
* unexpected results may occur. Instead, the user should reference
* standards(5) for correct usage of the standards feature test macros.
Roland