Re: pkg/37371 (Update multimedia/RealPlayerGold to 10.0.9.809.20070726)

[Brian de Alwis <bsd%cs.ubc.ca@localhost>]

The following reply was made to PR pkg/37371; it has been noted by GNATS.

From: Brian de Alwis <bsd%cs.ubc.ca@localhost>
To: OBATA Akio <obata%lins.jp@localhost>
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: pkg/37371 (Update multimedia/RealPlayerGold to
        10.0.9.809.20070726)
Date: Wed, 12 Dec 2007 23:17:32 -0600

 On 2007.12.10 15:01:42 +0900, OBATA Akio wrote:
 > It seems using same tool as rubyforge.
 > https://helixcommunity.org/frs/download.php/2479/RealPlayer-10.0.9.809-20070726.i586.rpm
 
 That's another great find.  I've respun the patch to use FETCH_CMD=wget
 with the above URL and attached it here; this is relative to
 multimedia/RealPlayerGold.  But there are two issues.  First, I'm
 not sure about specifying --no-check-certificate in FETCH_BEFORE_ARGS:
 it's necessary as wget doesn't have a default set of certificates
 (and I haven't installed such a set).
 
 Second, I don't see any support in the fetch framework to ensure
 that wget has been installed.  And it doesn't appear that simply
 placing a BUILD_DEPENDS check is sufficient as BUILD_DEPENDS aren't
 checked until after the fetch.
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/multimedia/RealPlayerGold/Makefile,v
 retrieving revision 1.19
 diff -w -b -u -r1.19 Makefile
 --- Makefile   9 Oct 2007 13:11:28 -0000       1.19
 +++ Makefile   13 Dec 2007 05:12:58 -0000
 @@ -4,10 +4,11 @@
  DISTNAME=             RealPlayer10GOLD
  # Exact version obtained from  the output of
  #   file RealPlayer10GOLD.rpm
 -PKGNAME=              RealPlayerGold-10.0.8.805.20060718
 -PKGREVISION=          2
 +PKGNAME=              RealPlayerGold-10.0.9.809.20070726
  CATEGORIES=           multimedia
 -MASTER_SITES=         http://forms.real.com/real/player/download.html?f=unix/
 +# The Helix Community seem to use the same tool as RubyForge,
 +# and are also hosting Linux RPMs of the Real Player
 +MASTER_SITES=         https://helixcommunity.org/frs/download.php/2479/
  EXTRACT_SUFX=         .rpm
  
  MAINTAINER=           pkgsrc-users%NetBSD.org@localhost
 @@ -23,6 +24,9 @@
  PKGVER=                       ${PKGNAME_NOREV:S/^RealPlayerGold-//}
  DIST_SUBDIR=          ${PKGNAME_NOREV}
  
 +FETCH_CMD=            wget
 +FETCH_BEFORE_ARGS+=   --no-check-certificate
 +
  WRKSRC=                       ${WRKDIR}
  BUILD_DIRS=           # empty
  
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/multimedia/RealPlayerGold/distinfo,v
 retrieving revision 1.6
 diff -w -b -u -r1.6 distinfo
 --- distinfo   29 Sep 2006 21:21:54 -0000      1.6
 +++ distinfo   13 Dec 2007 05:12:58 -0000
 @@ -1,5 +1,5 @@
  $NetBSD: distinfo,v 1.6 2006/09/29 21:21:54 dmcmahill Exp $
  
 -SHA1 (RealPlayerGold-10.0.8.805.20060718/RealPlayer10GOLD.rpm) = 
5bca48a23c747d19409330e6d6a94d49152cc557
 -RMD160 (RealPlayerGold-10.0.8.805.20060718/RealPlayer10GOLD.rpm) = 
0467c73f478f286483d5bd3a71dab3d0afd8dfb8
 -Size (RealPlayerGold-10.0.8.805.20060718/RealPlayer10GOLD.rpm) = 6649992 bytes
 +SHA1 (RealPlayerGold-10.0.9.809.20070726/RealPlayer10GOLD.rpm) = 
5231a724a1d3987400c79d066ff6b5c0ba3f5251
 +RMD160 (RealPlayerGold-10.0.9.809.20070726/RealPlayer10GOLD.rpm) = 
2a88652b0b9ab825d7fa3b63103e980005a58259
 +Size (RealPlayerGold-10.0.9.809.20070726/RealPlayer10GOLD.rpm) = 6645239 bytes
 -- 
   Brian de Alwis | Software Practices Lab | UBC | http://www.cs.ubc.ca/~bsd/
       "Amusement to an observing mind is study." - Benjamin Disraeli