Re: pkg/37634: x11/xproto gcc visibility solaris

[Gilles Dauphin <Gilles.Dauphin%enst.fr@localhost>]

The following reply was made to PR pkg/37634; it has been noted by GNATS.

From: Gilles Dauphin <Gilles.Dauphin%enst.fr@localhost>
To: solaris-pkg-people%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
    pkgsrc-bugs%NetBSD.org@localhost, dauphin%enst.fr@localhost, 
gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/37634: x11/xproto gcc visibility solaris
Date: Mon, 21 Jan 2008 14:58:36 +0100 (CET)

 > From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: pkg/37634: x11/xproto gcc visibility solaris
 > Date: Sun, 20 Jan 2008 17:03:02 +0100
 > 
 >  On Fri, Dec 28, 2007 at 11:45:01AM +0000, Gilles Dauphin wrote:
 >  > --- Xfuncproto.h.in.orig        Wed Oct 25 23:45:05 2006
 >  > +++ Xfuncproto.h.in     Sat Apr  7 01:31:26 2007
 >  > @@ -85,7 +85,7 @@
 >  >  # define _X_ATTRIBUTE_PRINTF(x,y)
 >  >  #endif /* GNUC >= 4 */
 >  >  
 >  > -#if defined(__GNUC__) && ((__GNUC__ * 100 + __GNUC_MINOR__) >= 303)
 >  > +#if defined(__GNUC__) && ((__GNUC__ * 100 + __GNUC_MINOR__) >= 303) && 
 !defined(__sun__)
 >  >  # define _X_EXPORT      __attribute__((visibility("default")))
 >  >  # define _X_HIDDEN      __attribute__((visibility("hidden")))
 >  >  # define _X_INTERNAL    __attribute__((visibility("internal")))
 >  
 >  The last update changed the logic a bit. Can you check if the new
 >  version works better? It enables them only for GCC 4.
 
 My PR is with gcc 4.1.2. 
 I look at gcc.gnu.org and the result is that visibility attribute is not
 supported for solaris 10 x86 with native Sun's ld.
 It was the case in gcc 3.4.3 for amd64, but now with x86 for all gcc4 series.
 
 by example look at :
 http://gcc.gnu.org/ml/java-patches/2007-q3/msg00060.html
 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32462
 
 Gilles