Re: pkg/37920: [fix] editors/abiword doesn't build on FreeBSD

[Juan RP <juan%xtrarom.org@localhost>]

The following reply was made to PR pkg/37920; it has been noted by GNATS.

From: Juan RP <juan%xtrarom.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/37920: [fix] editors/abiword doesn't build on FreeBSD
Date: Wed, 30 Jan 2008 10:37:51 +0100

 On Wed, 30 Jan 2008 09:30:01 +0000 (UTC)
 asau%inbox.ru@localhost wrote:
 
 > - src/af/util/xp/ut_iconv.cpp.orig   Thu Jan 24 09:18:16 2008
 > +++ src/af/util/xp/ut_iconv.cpp      Thu Jan 24 09:20:24 2008
 > @@ -67,7 +67,7 @@
 >  #if defined (WIN32) || defined(__QNXNTO__) || defined(__CYGWIN__) ||  \
 >  (defined (__MACH__) && defined (__APPLE__)) || \
 >  (defined(TARGET_OS_MAC) && TARGET_OS_MAC) || \
 > -defined (__AIX__) || defined(__OpenBSD__) || \
 > +defined (__AIX__) || defined(__OpenBSD__) || defined(__FreeBSD__) || \
 >  (defined(__linux__) && defined(__powerpc__) && (__GLIBC__ <= 2) && 
 > (__GLIBC_MINOR__ <= 1)) || \
 >  defined(__NetBSD__) || (defined(_LIBICONV_VERSION) && _LIBICONV_VERSION >= 
 > 0x0109 && !defined(__DragonFly__))
 >  
 > @@ -340,7 +340,7 @@
 >  #ifdef UT_ICONV_USING_GLIB
 >    return g_iconv((GIConv)cd, (char **)inbuf, inbytesleft, outbuf, 
 > outbytesleft);
 >  #else
 > -  return iconv( (iconv_t)cd, (ICONV_CONST char **)inbuf, inbytesleft, 
 > outbuf, outbytesleft );
 > +  return iconv( (iconv_t)cd, (char **)inbuf, inbytesleft, outbuf, 
 > outbytesleft );
 >  #endif
 >  }
 
 Why did you remove ICONV_CONST? NetBSD expects this:
 
      size_t
      iconv(iconv_t cd, const char ** restrict src, size_t * restrict srcleft,
          char ** restrict dst, size_t * restrict dstleft);
 
 -- 
 Juan Romero Pardines             The NetBSD Project
 http://plog.xtrarom.org/         NetBSD/pkgsrc news in Spanish
 http://mklivecd.xtrarom.org/     Make your own NetBSD Live CD/DVD!