pkg/37991: new scmgit doesn't build (at least on 3.1)

[dholland%eecs.harvard.edu@localhost]

>Number:         37991
>Category:       pkg
>Synopsis:       new scmgit (1.5.4) doesn't build on 3.1
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 10 06:15:00 +0000 2008
>Originator:     David A. Holland <dholland%eecs.harvard.edu@localhost>
>Release:        NetBSD 3.1_STABLE (20071106) pkgsrc 20080209
>Organization:
>Environment:
System: NetBSD rhett 3.1_STABLE NetBSD 3.1_STABLE (RHETT) #4: Thu Nov 8 
14:40:16 EST 2007 dholland@rhett:/usr/src/sys/arch/i386/compile/RHETT i386
Architecture: i386
Machine: i386
>Description:

scmgit (or more precisely, scmgit-base) fails like this:

            SUBDIR git-gui
        GITGUI_VERSION = 0.9.2
            * new locations or Tcl/Tk interpreter
            GEN git-gui
            INDEX lib/
            MSGFMT    po/de.msg gmake[1]: *** [po/de.msg] Error 1
        gmake: *** [all] Error 2
        *** Error code 2

On inspection it turns out to be because the makefile is trying to do

        msgfmt --statistics --tcl -l $(basename $(notdir $<)) -d $(dir $@) $<

and 3.1's msgfmt has never heard of these options.

I haven't tried this on 4.0 or current yet, but it looks like
current's msgfmt may accept this.

There then turns out to be another subdir, which apparently doesn't
share any config settings, that has the same problem.

>How-To-Repeat:

   cd devel/scmgit-base && make

>Fix:

Add this patch, or one that conditionalizes more specifically to 3.x:

--- git-gui/Makefile~   2008-02-10 00:42:05.000000000 -0500
+++ git-gui/Makefile    2008-02-10 00:47:09.000000000 -0500
@@ -131,6 +131,9 @@
                GITGUI_MACOSXAPP := YesPlease
        endif
 endif
+ifeq ($(uname_S),NetBSD)
+       NO_MSGFMT=1
+endif
 ifneq (,$(findstring MINGW,$(uname_S)))
        NO_MSGFMT=1
        GITGUI_WINDOWS_WRAPPER := YesPlease
--- gitk-git/Makefile~  2008-02-10 00:42:04.000000000 -0500
+++ gitk-git/Makefile   2008-02-10 00:49:07.000000000 -0500
@@ -16,6 +16,11 @@
 bindir_SQ = $(subst ','\'',$(bindir))
 TCLTK_PATH_SQ = $(subst ','\'',$(TCLTK_PATH))
 
+uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
+ifeq ($(uname_S),NetBSD)
+       NO_MSGFMT=1
+endif
+
 ## po-file creation rules
 XGETTEXT   ?= xgettext
 ifdef NO_MSGFMT