pkg/38418: chat/weechat added the wide-curses option

[leonardo1990%gmail.com@localhost]

>Number:         38418
>Category:       pkg
>Synopsis:       UTF-8 on chat/weechat doesn't work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 13 12:30:00 +0000 2008
>Originator:     Leonardo Taccari
>Release:        NetBSD 4.0
>Organization:
NetBSD Italia

Hello to all pkgsrc lovers,
chat/weechat on pkgsrc-2007Q4 doesn't support UTF-8. For example if I
join the #netbsd-it channel on Freenode I can't type (or type with
problems) UTF-8 characters. I've got this problem because chat/weechat
use ncurses and not ncursesw so for fix this problems I added a
wide-curses option to options.mk. I also turned that option by default
because IMHO the UTF-8 support is necessary.


HTH.

Ciao, Leonardo
-- 
 Leonardo Taccari (leot) | http://leot.netsons.org/
>Environment:
        
        
System: NetBSD bianconiglio 4.0 NetBSD 4.0 (BIANCONIGLIO) #0: Mon Mar 31 
16:52:15 CEST 2008 
leot@bianconiglio:/home/leot/builds/usr/src/sys/arch/i386/compile/BIANCONIGLIO 
i386
Architecture: i386
Machine: i386
>Description:
        The package chat/weechat doesn't support UTF-8. I've got this
        problem because it uses ncurses and not ncursesw, and there
        isn't any PKG_OPTIONS for turn on the wide-curses support. 

>How-To-Repeat:
        cd $PKGSRCDIR/chat/weechat && make install && weechat-curses
        /join #netbsd-it
        
        ...and now please type some UTF-8 characters. :-)

>Fix:
        Apply the attached patch that adds the wide-curses option, and
        turn on the wide-curses option (I use pkgsrc-2007Q4 but i'm
        quite sure that this patch can apply without any problems on
        pkgsrc-current).


Patch for chat/weechat/Makefile:

--- Makefile.orig       2008-04-13 12:48:19.000000000 +0200
+++ Makefile    2008-04-13 13:02:16.000000000 +0200
@@ -26,5 +26,4 @@
 
 .include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../converters/libiconv/buildlink3.mk"
-.include "../../devel/ncurses/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"


Patch for chat/weechat/options.mk:

--- options.mk.orig     2008-04-13 12:55:23.000000000 +0200
+++ options.mk  2008-04-13 13:05:20.000000000 +0200
@@ -1,8 +1,8 @@
 # $NetBSD: options.mk,v 1.3 2007/06/10 22:20:10 tonio Exp $
 
 PKG_OPTIONS_VAR=       PKG_OPTIONS.weechat
-PKG_SUPPORTED_OPTIONS= charset gnutls python lua
-PKG_SUGGESTED_OPTIONS= charset
+PKG_SUPPORTED_OPTIONS= charset gnutls lua python wide-curses
+PKG_SUGGESTED_OPTIONS= charset wide-curses
 
 .include "../../mk/bsd.options.mk"
 
@@ -18,6 +18,12 @@
 .include "../../security/gnutls/buildlink3.mk"
 .endif
 
+.if !empty(PKG_OPTIONS:Mwide-curses)
+.include "../../devel/ncursesw/buildlink3.mk"
+.else
+.include "../../devel/ncurses/buildlink3.mk"
+.endif
+
 .if !empty(PKG_OPTIONS:Mpython)
 .include "../../lang/python/extension.mk"
 CONFIGURE_ARGS+=       --enable-python

>Unformatted: