pkg/38509: pkgsrc/cairo gets the wrong ctime_r on Solaris

[sd4dfg2%hotmail.com@localhost]

>Number:         38509
>Category:       pkg
>Synopsis:       pkgsrc/cairo gets the wrong ctime_r on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 25 18:30:00 +0000 2008
>Originator:     Rob Quinn
>Release:        
>Organization:
>Environment:
>Description:
The Solaris man page shows two ctime_r definitions:

 SYNOPSIS
     #include <time.h>
 [...]
      char *ctime_r(const time_t *clock, char *buf, int buflen);
   Standard conforming
     cc [ flag... ] file... -D_POSIX_PTHREAD_SEMANTICS [ library... ]
     char *ctime_r(const time_t *clock, char *buf);


Cairo is using the 2 argument (standard conforming?) ctime_r call:
    [...]
    ctime_r (&now, ctime_buf),
    [...]
but getting the 3 argument:
 cairo-ps-surface.c:110: error: too few arguments to function `ctime_r'


>How-To-Repeat:
 gcc -DHAVE_CONFIG_H -I. -I.. -DPNG_NO_ASSEMBLER_CODE -D__EXTENSIONS__ 
-I/usr/obj/pkg/graphics/cairo/work/.buildlink/include 
-I/usr/obj/pkg/graphics/cairo/work/.buildlink/include/freetype2 
-I/usr/obj/pkg/graphics/cairo/work/.buildlink/include/libpng12 -DXTHREADS 
-I/usr/obj/pkg/graphics/cairo/work/.x11-buildlink/include 
-I/usr/obj/pkg/graphics/cairo/work/.buildlink/include/pixman-1 -Wall -Wextra 
-Wsign-compare -Werror-implicit-function-declaration -Wpointer-arith 
-Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wnested-externs -Wpacked -Wswitch-enum -Wmissing-format-attribute 
-Wstrict-aliasing=2 -Winit-self -Wdeclaration-after-statement 
-Wold-style-definition -Wno-unused-parameter -Wno-long-long -Winline 
-fno-strict-aliasing -D_REENTRANT -O -mv8 -pipe -MT 
libcairo_la-cairo-ps-surface.lo -MD -MP -MF 
.deps/libcairo_la-cairo-ps-surface.Tpo -c cairo-ps-surface.c  -fPIC -DPIC -o 
.libs/libcairo_la-cairo-ps-surface.o
cairo-ps-surface.c: In function `_cairo_ps_surface_emit_header':
cairo-ps-surface.c:110: error: too few arguments to function `ctime_r'
cairo-ps-surface.c: At top level:
cairo-ps-surface.c:3189: warning: missing initializer
cairo-ps-surface.c:3189: warning: (near initialization for 
`cairo_ps_surface_backend.is_similar')

>Fix:
I put in a third argument on the call, but I don't think that was the right 
solution.