pkg/38523: DESTDIR support for graphics/netpbm

[cheusov%tut.by@localhost]

>Number:         38523
>Category:       pkg
>Synopsis:       DESTDIR support for graphics/netpbm
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 27 09:30:01 +0000 2008
>Originator:     cheusov%tut.by@localhost
>Release:        NetBSD 4.0_STABLE
>Organization:
>Environment:
System: NetBSD chen.chizhovka.net 4.0_STABLE NetBSD 4.0_STABLE (GENERIC) #3: 
Wed Apr 23 00:58:08 EEST 2008 
cheusov%chen.chizhovka.net@localhost:/srv/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
http://www.mova.org/~cheusov/pub/pkgsrc-pbulk/NetBSD/current-destdir/log/20080426.0859/graphics/netpbm/stage_package.html

=> Checking file-check results for netpbm-10.34nb1
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /usr/pkg:
ERROR:         
/tmp/obj-pkgsrc-destdir/graphics/netpbm/work/.destdir/usr/pkg/bin/411toppm
ERROR:         
/tmp/obj-pkgsrc-destdir/graphics/netpbm/work/.destdir/usr/pkg/bin/anytopnm
ERROR:         
/tmp/obj-pkgsrc-destdir/graphics/netpbm/work/.destdir/usr/pkg/bin/asciitopgm
ERROR:         
/tmp/obj-pkgsrc-destdir/graphics/netpbm/work/.destdir/usr/pkg/bin/atktopbm
...
ERROR:         
/tmp/obj-pkgsrc-destdir/graphics/netpbm/work/.destdir/usr/pkg/share/netpbm/rgb.txt
*** Error code 1

Stop.
make: stopped in /srv/pkgsrc/graphics/netpbm
*** Error code 1
>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/netpbm/Makefile,v
retrieving revision 1.156
diff -u -r1.156 Makefile
--- Makefile    8 Feb 2008 10:34:19 -0000       1.156
+++ Makefile    27 Apr 2008 09:26:05 -0000
@@ -13,6 +13,7 @@
 MAKE_JOBS_SAFE=        no
 
 PKG_INSTALLATION_TYPES=        overwrite pkgviews
+PKG_DESTDIR_SUPPORT=   user-destdir
 
 USE_TOOLS+=    bash:run gmake lex perl
 USE_FEATURES=  snprintf
@@ -95,9 +96,9 @@
                ${TEST} -d "${PREFIX}/$${DIR}" ||               \
                        ${ECHO} "@dirrm $${DIR}";               \
        done >>${PLIST_SRC} &&                                  \
-       ${PAX} -rwpppm . ${PREFIX}
+       ${PAX} -rwpppm . ${DESTDIR}${PREFIX}
        ${RM} -fr ${STAGEDIR}
-       ${FIND} ${PREFIX}/share/doc/netpbm -type f -print |     \
+       ${FIND} ${DESTDIR}${PREFIX}/share/doc/netpbm -type f -print |   \
                ${XARGS} ${CHMOD} ${NONBINMODE}
 
 .include "../../mk/bsd.pkg.mk"