Re: pkg/38479: current version of silc-client has security holes

To: pkg-manager%netbsd.org@localhost,gnats-admin%netbsd.org@localhost,pkgsrc-bugs%netbsd.org@localhost,keith+pkgsrc%lib.uchicago.edu@localhost
Subject: Re: pkg/38479: current version of silc-client has security holes
From: César Catrián Carreño <ccatrian%eml.cc@localhost>
Date: Sun, 4 May 2008 19:15:06 +0000 (UTC)
The following reply was made to PR pkg/38479; it has been noted by GNATS.

From: =?UTF-8?B?Q8Opc2FyIENhdHJpw6FuIENhcnJlw7Fv?= <ccatrian%eml.cc@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/38479: current version of silc-client has security holes
Date: Sun, 4 May 2008 15:13:13 -0400

 Please review these patches. Note: patch-aa and patch-ad must be nuked.
 
 --- chat/silc-client/Makefile.orig      2008-05-01 21:47:21.000000000 -0400
 +++ chat/silc-client/Makefile   2008-05-04 14:14:27.000000000 -0400
 @@ -26,21 +26,22 @@
  EGDIR=                 ${PREFIX}/share/examples/${PKGBASE}
  MAKE_ENV+=             examplesdir=${EGDIR:Q}
  
 -CONF_FILES+=           ${EGDIR}/silc.conf.default ${PKG_SYSCONFDIR}/silc.conf
 +CONF_FILES+=           ${EGDIR}/example_silc.conf ${PKG_SYSCONFDIR}/silc.conf
  
  CONFIGURE_ARGS+=       --libdir=${PREFIX}/lib/${PKGBASE}
  CONFIGURE_ARGS+=       --with-helpdir=${PREFIX}/share/${PKGBASE}/help
  CONFIGURE_ARGS+=       --with-docdir=${PREFIX}/share/doc/${PKGBASE}
 -CONFIGURE_ARGS+=       --with-etcdir=${PKG_SYSCONFDIR:Q}
 -CONFIGURE_ARGS+=       --with-simdir=${PREFIX}/lib/${PKGBASE}/modules
 +CONFIGURE_ARGS+=       --sysconfdir=${PKG_SYSCONFDIR:Q}
 +#CONFIGURE_ARGS+=      --with-simdir=${PREFIX}/lib/${PKGBASE}/modules
  CONFIGURE_ARGS+=       --with-iconv=${BUILDLINK_DIR:Q}
 -CONFIGURE_ARGS+=       --with-terminfo
 +#CONFIGURE_ARGS+=      --with-terminfo
  CONFIGURE_ARGS+=       --enable-shared
  CONFIGURE_ARGS+=       --without-libtoolfix
  
  .include "../../mk/bsd.prefs.mk"
  
  # Use native curses library.
 +.include "../../mk/curses.buildlink3.mk"
  .if (${OPSYS} == "NetBSD") || (${OPSYS} == "SunOS")
  CONFIGURE_ARGS+=       --with-vcurses
  .elif (${OPSYS} == "Linux") || (${OPSYS} == "Darwin")
 @@ -79,6 +80,5 @@
  
  .include "../../converters/libiconv/buildlink3.mk"
  .include "../../devel/glib/buildlink3.mk"
 -.include "../../devel/ncurses/buildlink3.mk"
  
  .include "../../mk/bsd.pkg.mk"
 
 
 --- chat/silc-client/Makefile.common.orig       2008-05-01 21:47:35.000000000 
-0400
 +++ chat/silc-client/Makefile.common    2008-05-04 14:30:34.000000000 -0400
 @@ -3,7 +3,7 @@
  
  # Distribution specific information.
  #
 -SILC_CLIENT_VERSION=           1.0.4.1
 +SILC_CLIENT_VERSION=           1.1.4
  SILC_CLIENT_DISTNAME=          silc-client-${SILC_CLIENT_VERSION}
  SILC_CLIENT_EXTRACT_SUFX=      .tar.bz2
  SILC_CLIENT_DISTFILE=          
${SILC_CLIENT_DISTNAME}${SILC_CLIENT_EXTRACT_SUFX}
 
 
 --- chat/silc-client/PLIST.orig 2008-05-01 22:21:46.000000000 -0400
 +++ chat/silc-client/PLIST      2008-05-04 14:50:23.000000000 -0400
 @@ -2,29 +2,7 @@
  bin/silc     
  lib/silc-client/libsilc.la
  lib/silc-client/libsilcclient.la
 -lib/silc-client/modules/aes.sim.so
 -lib/silc-client/modules/blowfish.sim.so
 -lib/silc-client/modules/cast.sim.so
 -lib/silc-client/modules/md5.sim.so
 -lib/silc-client/modules/none.sim.so
 -lib/silc-client/modules/rc5.sim.so
 -lib/silc-client/modules/rsa.sim.so
 -lib/silc-client/modules/sha1.sim.so
 -lib/silc-client/modules/twofish.sim.so
  man/man1/silc.1
 -share/doc/silc-client/CHANGES
 -share/doc/silc-client/COPYING
 -share/doc/silc-client/CREDITS
 -share/doc/silc-client/FAQ
 -share/doc/silc-client/INSTALL
 -share/doc/silc-client/README
 -share/doc/silc-client/TODO
 -share/doc/silc-client/formats.txt
 -share/doc/silc-client/manual.txt
 -share/doc/silc-client/signals.txt
 -share/doc/silc-client/special_vars.txt
 -share/doc/silc-client/startup-HOWTO.html
 -share/examples/silc-client/silc.conf.default
  share/silc-client/config.h
  share/silc-client/help/action
  share/silc-client/help/admin
 @@ -85,6 +63,7 @@
  share/silc-client/help/ping
  share/silc-client/help/query
  share/silc-client/help/quit
 +share/silc-client/help/recode
  share/silc-client/help/reconnect
  share/silc-client/help/reload
  share/silc-client/help/rmreconns
 @@ -115,11 +94,25 @@
  share/silc-client/help/whowas
  share/silc-client/help/window
  share/silc-client/irssi-config
 +share/doc/silc-client/CHANGES
 +share/doc/silc-client/COPYING
 +share/doc/silc-client/CREDITS
 +share/doc/silc-client/FAQ
 +share/doc/silc-client/INSTALL
 +share/doc/silc-client/README
 +share/doc/silc-client/README.PLUGIN
 +share/doc/silc-client/TODO
 +share/doc/silc-client/formats.txt
 +share/doc/silc-client/manual.txt
 +share/doc/silc-client/signals.txt
 +share/doc/silc-client/special_vars.txt
 +share/doc/silc-client/startup-HOWTO.html
 +share/examples/silc-client/example_silc.conf
  share/silc-client/themes/default.theme
 +share/silc-client/themes/plugin.theme
 +@dirrm share/doc/silc-client
 +@dirrm share/examples/silc-client
  @dirrm share/silc-client/themes
  @dirrm share/silc-client/help
  @dirrm share/silc-client
 -@dirrm share/examples/silc-client
 -@dirrm share/doc/silc-client
 -@dirrm lib/silc-client/modules
  @dirrm lib/silc-client
 
 
 --- chat/silc-client/distinfo.orig      2008-05-01 21:49:18.000000000 -0400
 +++ chat/silc-client/distinfo   2008-05-04 14:42:50.000000000 -0400
 @@ -1,9 +1,8 @@
  $NetBSD: distinfo,v 1.31 2007/05/18 21:04:25 salo Exp $
  
 -SHA1 (silc-client-1.0.4.1.tar.bz2) = 29d8cd4208db23e997bedf6271fc0dfd0cb84e6c
 -RMD160 (silc-client-1.0.4.1.tar.bz2) = 
46abb8312d37842e20e01f79566460ee486c1bbf
 -Size (silc-client-1.0.4.1.tar.bz2) = 1445091 bytes
 -SHA1 (patch-aa) = cbb65b6a6eb312d79b0e1ab5915841ed7730321d
 -SHA1 (patch-ab) = 41bc37c379be30cab6540a3c30cad3163d30dff0
 -SHA1 (patch-ac) = 8267934b89e67c3d3168bb290abcac53b9b17658
 -SHA1 (patch-ad) = bd414db383a0c7d9c235523053f4d96c50be8199
 +SHA1 (silc-client-1.1.4.tar.bz2) = 043fd02ffc0bb420d411c4ca14ad307b48beaa06
 +RMD160 (silc-client-1.1.4.tar.bz2) = 519ba59912da4bb514330ca8e87979844f957ad0
 +Size (silc-client-1.1.4.tar.bz2) = 1624696 bytes
 +SHA1 (patch-ab) = f15b0f6247163a042fb3ed924ac97dcf3ec881f0
 +SHA1 (patch-ac) = 56f2262a5307477dbfb33588f71cd5ebf7b1812d
 +SHA1 (patch-ae) = b5323b04aced81d2efa2ef7426081f2592f3da77
 
 
 --- chat/silc-client/patches/patch-ab.orig      2008-05-04 15:09:22.000000000 
-0400
 +++ chat/silc-client/patches/patch-ab   2008-05-04 13:00:14.000000000 -0400
 @@ -1,9 +1,7 @@
 -$NetBSD: patch-ab,v 1.12 2007/05/18 21:04:25 salo Exp $
 -             
 ---- apps/irssi/Makefile.in.orig        2007-03-07 19:02:19.000000000 +0000
 -+++ apps/irssi/Makefile.in     2007-05-18 20:19:04.000000000 +0000
 -@@ -282,7 +282,7 @@ sysconfdir = @sysconfdir@
 - target_alias = @target_alias@
 +--- apps/irssi/Makefile.in.orig        2008-03-20 02:47:18.000000000 -0400
 ++++ apps/irssi/Makefile.in     2008-05-04 12:59:37.000000000 -0400
 +@@ -276,7 +276,7 @@
 + top_srcdir = @top_srcdir@
   @BUILD_PLUGINS_TRUE@PLUGINS = plugins
   @BUILD_SERVERTEST_TRUE@SERVERTEST = servertest
  -SUBDIRS = src docs scripts
 @@ -11,12 +9,36 @@
   
   #
   # INCLUDE defines
 -@@ -297,7 +297,7 @@ INCLUDES = $(ADD_INCLUDES) $(SILC_CFLAGS
 +@@ -291,7 +291,7 @@
   #confdir = $(sysconfdir)
   confdir = $(silc_etcdir)
   conffile = silc.conf
 --themedir = $(datadir)/silc/themes
 -+themedir = $(datadir)/silc-client/themes
 - theme_DATA = default.theme
 - noinst_HEADERS = irssi-version.h.in
 - EXTRA_DIST = \
 +-@SILCPLUGIN_FALSE@themedir = $(datadir)/silc/themes
 ++@SILCPLUGIN_FALSE@themedir = $(datadir)/silc-client/themes
 + @SILCPLUGIN_TRUE@themedir = $(datadir)/irssi/themes
 + @SILCPLUGIN_FALSE@theme_DATA = default.theme plugin.theme
 + @SILCPLUGIN_TRUE@theme_DATA = plugin.theme
 +@@ -811,11 +811,11 @@
 +       rpm -ta --clean $(PACKAGE)-$(VERSION).tar.gz
 +             
 + install-dirs-client:
 +-      -mkdir -p $(docdir)
 ++      -mkdir -p $(examplesdir)
 +       -mkdir -p $(mandir)/man1
 +             
 + doc-install-client:
 +-      $(INSTALL_DATA) $(silc_top_srcdir)/apps/irssi/silc.conf 
$(docdir)/example_silc.conf
 ++      $(INSTALL_DATA) $(silc_top_srcdir)/apps/irssi/silc.conf 
$(examplesdir)/example_silc.conf
 +       -@if test -f $(silc_top_srcdir)/doc/silc.1 ; then \
 +        $(INSTALL_DATA) $(silc_top_srcdir)/doc/silc.1 $(mandir)/man1; \
 +       fi    
 +@@ -831,8 +831,7 @@
 +             
 + install-data-hook:            \
 +       install-dirs-client     \
 +-      doc-install-client      \
 +-      $(ETCINSTALL)
 ++      doc-install-client
 + # Tell versions [3.59,3.63) of GNU make to not export all variables.
 + # Otherwise a system limit (for SysV at least) may be exceeded.
 + .NOEXPORT:  
 
 
 --- chat/silc-client/patches/patch-ac.orig      2008-05-04 15:09:37.000000000 
-0400
 +++ chat/silc-client/patches/patch-ac   2008-05-04 13:02:04.000000000 -0400
 @@ -1,13 +1,11 @@
 -$NetBSD: patch-ac,v 1.9 2007/05/18 21:04:25 salo Exp $
 -
 ---- apps/irssi/src/perl/Makefile.in.orig       2006-01-06 14:46:28.000000000 
+0100
 -+++ apps/irssi/src/perl/Makefile.in    2006-01-08 20:47:56.000000000 +0100
 -@@ -281,7 +281,7 @@
 -       -I$(top_srcdir)/src/fe-common/core \
 -       -I$(top_srcdir)/src/fe-common/silc \
 -       $(GLIB_CFLAGS) \
 --      -DSCRIPTDIR=\""$(datadir)/silc/scripts"\" \
 -+      -DSCRIPTDIR=\""$(prefix)/libexec/silc-client/scripts"\" \
 -       -DPERL_USE_LIB=\""$(PERL_USE_LIB)"\" \
 -       -DPERL_STATIC_LIBS=$(PERL_STATIC_LIBS) \
 -       $(PERL_CFLAGS)
 +--- apps/irssi/src/perl/Makefile.in.orig       2008-05-04 13:00:59.000000000 
-0400
 ++++ apps/irssi/src/perl/Makefile.in    2008-05-04 13:01:30.000000000 -0400
 +@@ -291,7 +291,7 @@
 + moduledir = @SILC_IRSSIDIR@
 + @SILCPLUGIN_FALSE@perl_dirs = common ui textui silc
 + @SILCPLUGIN_TRUE@perl_dirs = silc
 +-@SILCPLUGIN_FALSE@SCRIPTDIR = "$(datadir)/silc/scripts"
 ++@SILCPLUGIN_FALSE@SCRIPTDIR = "$(datadir)/silc-client/scripts"
 + @SILCPLUGIN_TRUE@SCRIPTDIR = "$(datadir)/irssi/scripts"
 + module_LTLIBRARIES = $(perl_module_lib) $(perl_module_fe_lib)
 + noinst_LTLIBRARIES = $(perl_static_lib) $(perl_static_fe_lib)
 
 
 --- /dev/null   2008-05-04 14:51:44.000000000 -0400
 +++ chat/silc-client/patches/patch-ae   2008-05-04 14:42:32.000000000 -0400
 @@ -0,0 +1,11 @@
 +--- apps/irssi/docs/help/Makefile.in.orig      2008-05-04 14:41:48.000000000 
-0400
 ++++ apps/irssi/docs/help/Makefile.in   2008-05-04 14:41:59.000000000 -0400
 +@@ -211,7 +211,7 @@
 + target_alias = @target_alias@
 + top_builddir = @top_builddir@
 + top_srcdir = @top_srcdir@
 +-@SILCPLUGIN_FALSE@helpdir = $(datadir)/silc/help
 ++@SILCPLUGIN_FALSE@helpdir = $(datadir)/silc-client/help
 + @SILCPLUGIN_TRUE@helpdir = $(datadir)/irssi/help/silc
 + @SILCPLUGIN_FALSE@SILCHELP = 
 + @SILCPLUGIN_TRUE@SILCHELP = silc
Prev by Date: Re: pkg/37648: lang/python22 fails under Linux
Next by Date: Re: pkg/38575 (gpsd has a bad PLIST or bad installation)
Previous by Thread: pkg/38479: current version of silc-client has security holes
Next by Thread: Re: pkg/38446: fontforge 2008Q1 blows up in compilation with undefined references
Indexes:
Home | Main Index | Thread Index | Old Index