pkg/39062: security/dsniff-nox11 build fails on MacOS 10.4.11

[jdbaker%mylinuxisp.com@localhost]

>Number:         39062
>Category:       pkg
>Synopsis:       security/dsniff-nox11 build fails on MacOS 10.4.11
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 28 20:25:00 +0000 2008
>Originator:     John D. Baker
>Release:        MacOS X 10.4.11 pkgsrc-2008Q1
>Organization:
>Environment:
Darwin aardvark-2.local 8.11.1 Darwin Kernel Version 8.11.1: Wed Oct 10 
18:23:28 PDT 2007; root:xnu-792.25.20~1/RELEASE_I386 i386 i386

>Description:
security/dsniff fails building with:

[...]
gcc -pipe -O2 -I/usr/include -I/usr/pkg/include/libnet10 -I/usr/pkg/include 
-D_BSD_SOURCE -DLIBNET_LIL_ENDIAN -DDSNIFF_LIBDIR=\"/usr/pkg/lib/\" -I. 
-I/usr/pkg/include  -I/usr/pkg/include/libnet10     -I./missing -c ./dnsspoof.c
./dnsspoof.c: In function 'dns_spoof':
./dnsspoof.c:183: error: 'HEADER' undeclared (first use in this function)
./dnsspoof.c:183: error: (Each undeclared identifier is reported only once
./dnsspoof.c:183: error: for each function it appears in.)
./dnsspoof.c:183: error: 'dns' undeclared (first use in this function)
./dnsspoof.c:192: error: parse error before ')' token
./dnsspoof.c:199: error: 'QUERY' undeclared (first use in this function)
./dnsspoof.c:210: error: 'C_IN' undeclared (first use in this function)
./dnsspoof.c:215: error: 'T_A' undeclared (first use in this function)
./dnsspoof.c:224: error: 'T_PTR' undeclared (first use in this function)
./dnsspoof.c:225: warning: pointer targets in assignment differ in signedness
./dnsspoof.c:229: warning: pointer targets in passing argument 1 of 
'res_9_dn_comp' differ in signedness
./dnsspoof.c:245: error: parse error before ')' token
*** Error code 1
[...]

>How-To-Repeat:
Attempt to build security/dsniff-nox11 on MacOS X 10.4.11
>Fix:
work/dsniff-2.3/dnsspoof.c includes <arpa/nameser.h>.  On MacOS X 10.4.11,
this supports the BIND9 API, but "dsniff-nox11" and friends are written
for BIND 8 or earlier, only.

There is a conditional include of <arpa/nameser8_compat.h> that depends
on BIND_8_COMPAT being defined.

As a workaround, [b]make configure, then adding

  #define BIND_8_COMPAT

to work/dsniff-2.3/config.h allows it to compile.