pkg/39234: lang/gcc34/buildlink3.mk sets the wrong BUILDLINK_DEPMETHOD

[Taylor R Campbell <campbell%mumble.net@localhost>]

>Number:         39234
>Category:       pkg
>Synopsis:       lang/gcc34/buildlink3.mk sets the wrong BUILDLINK_DEPMETHOD
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 28 02:05:00 +0000 2008
>Originator:     campbell%mumble.net@localhost
>Release:        NetBSD 4.0_STABLE
>Organization:
>Environment:
System: NetBSD slate.localdomain 4.0_STABLE NetBSD 4.0_STABLE (GENERIC) #0: Sat 
Jun 7 06:55:02 UTC 2008 
riastradh%slate.localdomain@localhost:/home/riastradh/netbsd/4/obj/sys/arch/macppc/compile/GENERIC
 macppc
Architecture: powerpc
Machine: macppc
>Description:

        lang/gcc34/buildlink3.mk sets the BUILDLINK_DEPMETHOD.gcc
        variable, but it should set BUILDLINK_DEPMETHOD.gcc34 or else
        mk/buildlink3/bsd.buildlink3.mk will disregard the setting
        altogether.  As a consequence of setting the wrong variable,
        buildlink3 uses the default dependency method for lang/gcc34,
        `full', which causes packages using it to record a full
        run-time dependency on it even when they require it only for a
        compile-time build dependency.

        (This is a trifle tricky to stumble across: only two packages
        actually depend on GCC 3.4 on more than one architecture,
        misc/openoffice2 and net/aria2.  I stumbled across it only
        because GCC 3.3 is broken on NetBSD 4.0/macppc, and the
        emulators/qemu package needs GCC 3, so after manually adding
        3.4 to GCC_REQD, I noticed a strange full run-time dependency
        on GCC 3.4 that I had not observed when I built emulators/qemu
        yesterday on NetBSD 4.0/i386.)

>How-To-Repeat:
>Fix:

        Change BUILDLINK_DEPMETHOD.gcc to BUILDLINK_DEPMETHOD.gcc34 in
        lang/gcc34/buildlink3.mk:

--- buildlink3.mk.~1~   Wed Jan 17 03:11:19 2007
+++ buildlink3.mk       Fri Jul 18 19:57:24 2008
@@ -40,7 +40,7 @@
 
 # Packages that link against shared libraries need a full dependency.
 .  if defined(_USE_GCC_SHLIB)
-BUILDLINK_DEPMETHOD.gcc+=      full
+BUILDLINK_DEPMETHOD.gcc34+=    full
 .  else
-BUILDLINK_DEPMETHOD.gcc?=      build
+BUILDLINK_DEPMETHOD.gcc34?=    build
 .  endif