pkg/39312: lang/php5 has no way to enable thread safety or outgoing ftp

[riz%newdev.local@localhost]

>Number:         39312
>Category:       pkg
>Synopsis:       No way to enable certain options when building PHP
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 07 17:20:00 +0000 2008
>Originator:     Jeff Rizzo <riz%tastylime.net@localhost>
>Release:        NetBSD 4.99.72
>Organization:
>Environment:
System: NetBSD newdev.local 4.99.72 NetBSD 4.99.72 (GENERIC) #0: Mon Aug 4 
19:04:59 PDT 2008 
builds@wb28:/home/builds/ab/HEAD/amd64/200808040002Z-obj/home/builds/ab/HEAD/src/sys/arch/amd64/compile/GENERIC
 amd64
Architecture: x86_64
Machine: amd64
>Description:
        When running Apache 2.2 with the worker MPM, php does not behave
        itself unless thread safety is on, using the --enable-maintainer-zts
        option at build time.  Also, our application needs to make
        outgoing ftp connections, which also needs to be enabled at
        build time.
>How-To-Repeat:
        Build lang/php5, try to enable those options
>Fix:
        Apply the following patch, then build using the new options.
        Not sure how correct this is in the current pkgsrc scheme, so
        feel free to alter.  The patch applies in pkgsrc/lang/php5 .


Index: Makefile.php
===================================================================
RCS file: /cvsroot/pkgsrc/lang/php5/Makefile.php,v
retrieving revision 1.27
diff -u -r1.27 Makefile.php
--- Makefile.php        8 Jul 2008 20:28:55 -0000       1.27
+++ Makefile.php        7 Aug 2008 15:49:29 -0000
@@ -41,7 +41,7 @@
 # Note: This expression is the same as ${PKGBASE}, but the latter is
 # not defined yet, so we cannot use it here.
 PKG_OPTIONS_VAR=       PKG_OPTIONS.${PKGNAME:C/-[0-9].*//}
-PKG_SUPPORTED_OPTIONS+=        inet6 ssl
+PKG_SUPPORTED_OPTIONS+=        inet6 ssl maintainer-zts ftp
 PKG_SUGGESTED_OPTIONS+=        ssl
 
 .include "../../mk/bsd.options.mk"
@@ -58,3 +58,11 @@
 .else
 CONFIGURE_ARGS+=       --without-openssl
 .endif
+
+.if !empty(PKG_OPTIONS:Mftp)
+CONFIGURE_ARGS+=       --enable-ftp
+.endif
+
+.if !empty(PKG_OPTIONS:Mmaintainer-zts)
+CONFIGURE_ARGS+=       --enable-maintainer-zts
+.endif