Re: pkg/39287: devel/doxymacs fails to configure with xemacs

[david.sainty%dtsp.co.nz@localhost]

anthony.mallet%useless-ficus.net@localhost writes:

> >Number:         39287
> >Category:       pkg
> >Synopsis:       devel/doxymacs fails to configure with xemacs
> >Confidential:   no
> >Severity:       serious
> >Priority:       low
> >Responsible:    pkg-manager
> >State:          open
> >Class:          sw-bug
> >Submitter-Id:   net
> >Arrival-Date:   Mon Aug 04 20:40:00 +0000 2008
> >Originator:     anthony.mallet%useless-ficus.net@localhost
> >Release:        NetBSD 4.99.72
> >Organization:
>       
> >Environment:
>       
>       
> System: NetBSD ficus 4.99.72 NetBSD 4.99.72 (FICUS) #6: Sat Aug 2 14:52:55 
> CEST 2008 troot@ficus:/usr/obj/sys/arch/i386/compile/FICUS i386
> Architecture: i386
> Machine: i386
> >Description:
> make in pkgsrc/devel/doxymacs with EMACS_TYPE=xemacs214 set in mk.conf
> wants to depend on www/w3 which doesn't make sense for xemacs.
> 
> The lisp dir is also not configured correctly when using xemacs. 
> >How-To-Repeat:
> cd pkgsrc/devel/doxymacs && make update
> >Fix:
> diff -u -r1.4 Makefile
> --- Makefile    5 Aug 2007 05:19:19 -0000       1.4
> +++ Makefile    4 Aug 2008 20:29:14 -0000
> @@ -19,12 +19,13 @@
>  # Fortunately, the url-* support from Emacs/W3 has been integrated
>  # into Emacs version 22.
>  #
> -.if ${EMACS_VERSION_MAJOR} <= 21
> +.if ${EMACS_FLAVOR} == emacs && ${EMACS_VERSION_MAJOR} <= 21
>  DEPENDS+=      w3-[0-9]*:../../www/w3
>  .endif
>  
>  GNU_CONFIGURE= yes
>  CONFIGURE_ENV+=        EMACS=${EMACS_BIN:Q}
> +CONFIGURE_ARGS+=     --with-lispdir=${EMACS_LISPPREFIX}
>  
>  .include "../../textproc/libxml2/buildlink3.mk"
>  .include "../../mk/bsd.pkg.mk"

Looking at the PLISTs I see that the url-*.el files for xemacs (the
files that Doxymacs wants) don't appear in the editor package, but in
"editors/xemacs-packages".

editors/emacs/PLIST:share/emacs/${PKGVERSION}/lisp/url/url-http.elc
editors/xemacs-packages/PLIST:lib/xemacs/xemacs-packages/lisp/w3/url-http.elc

I suspect that means the condition should actually be something like:

.if ${EMACS_FLAVOR} == xemacs
DEPENDS+=       xemacs-packages-[0-9]*:../../editors/xemacs-packages
.elif ${EMACS_VERSION_MAJOR} <= 21
DEPENDS+=       w3-[0-9]*:../../www/w3
.endif

Does this look right to you?

Thanks,

Dave