pkg/39418: multimedia/gst-plugins0.10-good fails to build

[David.Sainty%dtsp.co.nz@localhost]

>Number:         39418
>Category:       pkg
>Synopsis:       multimedia/gst-plugins0.10-good fails to build
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 27 09:15:00 +0000 2008
>Originator:     David Sainty
>Release:        
>Organization:
>Environment:
Linux 2.6.16.27-0.9-smp #1 SMP Tue Feb 13 09:35:18 UTC 2007 i686 i686 i386 
GNU/Linux

>Description:
X based plugins fail to link with libX11, because it isn't a dependency.  Also, 
the PLIST doesn't contain files for gst_v4l2.

 gcc -shared  .libs/libgstximagesrc_la-gstximagesrc.o 
.libs/libgstximagesrc_la-ximageutil.o  -Wl,--rpath 
-Wl,/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib 
-Wl,--rpath 
-Wl,/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib 
-L/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib 
/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib/libgstbase-0.10.so
 
/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib/libgstreamer-0.10.so
 
/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib/libgobject-2.0.so
 
/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib/libgmodule-2.0.so
 -ldl 
/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib/libgthread-2.0.so
 -lpthread -lrt 
/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib/libxml2.so
 
/home/pkgsrc2/pkgsrc/multimedia/gst-plugins0.10-good/work/.buildlink/lib/libglib-
 2.0.so -lX11  -Wl,-R/usr/pkgroot2/lib -pthread -pthread -Wl,-soname 
-Wl,libgstximagesrc.so -Wl,-version-script -Wl,.libs/libgstximagesrc.ver -o 
.libs/libgstximagesrc.so
/usr/lib/gcc/i586-suse-linux/4.1.0/../../../../i586-suse-linux/bin/ld: cannot 
find -lX11
collect2: ld returned 1 exit status
make[3]: *** [libgstximagesrc.la] Error 1

>How-To-Repeat:
Build the package in exactly the environment on this box :)
>Fix:
This patch prunes out the plugins at fault.  If the X plugins are actually 
intended to be part of this package then the appropriate buildlinks must be 
added instead.


--- pkgsrc/multimedia/gst-plugins0.10-good/Makefile.common        2008-08-19 
10:34:38.000000000 +1200
+++ pkgsrc/multimedia/gst-plugins0.10-good/Makefile.common      2008-08-27 
20:49:17.000000000 +1200
@@ -16,6 +16,7 @@
                flac \
                gconf \
                gconftool \
+               gst_v4l2 \
                jpeg \
                ladspa \
                libcaca \
@@ -26,6 +27,9 @@
                shout2test \
                speex \
                sunaudio \
+               x \
+               xshm \
+               xvideo \
                zlib
 CONFIGURE_ARGS+=       --disable-${driver}
 .endfor