pkg/39453: bootstrap fails on Solaris after latest changes to lang/nawk

["Joachim König" <him%online.de@localhost>]

>Number:         39453
>Category:       pkg
>Synopsis:       bootstrap fails on Solaris after latest changes to lang/nawk
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 03 07:55:00 +0000 2008
>Originator:     Joachim König
>Release:        NetBSD 4.99.72 i386
>Organization:
totally unorganized 
>Environment:


System: SunOS-5.9 and SunOS-5.10 with Sun Studio 12 compiler



>Description:


lang/nawk/files/tran.c was changed in revision 1.2 the following way:

 char *tostring(const char *s)  /* make a copy of string s */
 {
        char *p;
 
        p = (char *) malloc(strlen(s)+1);
        if (p == NULL)
                FATAL("out of space in tostring on %s", s);
-       strcpy(p, s);
        return(p);
 }
 
 with the commit message:  

   Remove hard-coded limit on FS. Merge minor performance 
   improvements. Bump revision.

Obviously, the method now does not copy the string to the new buffer any more. 
This should be undone.


>How-To-Repeat:


Try to bootstrap pkgsrc on SunOS/Solaris and see it fail with a
nawk error message when building bootstrap-mk-files.


>Fix:


undo revision 1.2 of files/tran.c