Re: pkg/39531: bootstrap fails on Interix (patches for net/tnftp)

[Min Sik Kim <minskim%NetBSD.org@localhost>]

The following reply was made to PR pkg/39531; it has been noted by GNATS.

From: Min Sik Kim <minskim%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/39531: bootstrap fails on Interix (patches for net/tnftp)
Date: Sun, 14 Sep 2008 14:00:33 -0700

 Aleksey,
 
 Could you try the following patch? With that, curses.buildlink3.mk  
 will identify the native curses library correctly, and tnftp will no  
 longer depend on the pkgsrc version of ncurses.
 
 --
 Min Sik Kim
 
 
 diff -u -r1.12 curses.buildlink3.mk
 --- mk/curses.buildlink3.mk    29 Feb 2008 16:29:04 -0000      1.12
 +++ mk/curses.buildlink3.mk    14 Sep 2008 20:56:36 -0000
 @@ -42,13 +42,6 @@
   # Set the value of CURSES_DEFAULT depending on the platform and what's
   # available in the base system.
   #
 -# - Interix has an unusual ncurses installation that is missing some
 -#   shared libraries, but the ncurses/builtin.mk will take care of  
 things
 -#   for us.
 -#
 -.if ${OPSYS} == "Interix"
 -CURSES_DEFAULT?=      ncurses
 -.endif
   .if defined(USE_BUILTIN.curses) && !empty(USE_BUILTIN.curses:M[yY] 
 [eE][sS])
   CURSES_DEFAULT?=     curses
   .else
 
 
 
 
 
 --
 Min Sik Kim
 
 
 
 
 On Sep 13, 2008, at 1:05 AM, cheusov%tut.by@localhost wrote:
 
 >> Number:         39531
 >> Category:       pkg
 >> Synopsis:       bootstrap fails on Interix (patch for net/tnftp)
 >> Confidential:   no
 >> Severity:       serious
 >> Priority:       high
 >> Responsible:    pkg-manager
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Sat Sep 13 08:05:00 +0000 2008
 >> Originator:     cheusov%tut.by@localhost
 >> Release:        NetBSD 4.0_STABLE
 >> Organization:
 >> Environment:
 > System: NetBSD chen.chizhovka.net 4.0_STABLE NetBSD 4.0_STABLE  
 > (GENERIC) #0: Wed Jul 16 00:28:58 EEST 2008  
 > cheusov%chen.chizhovka.net@localhost:/srv/obj/sys/arch/i386/compile/GENERIC 
 > i386
 > Architecture: i386
 > Machine: i386
 >> Description:
 > bootstrap on Interix fails. It ends like this
 >
 >   => Returning to build of ncurses-5.6nb2
 >   => Bootstrap dependency tnftp-[0-9]*: NOT found
 >   => Verifying reinstall for ../../net/tnftp
 >   ERROR: This package has set PKG_FAIL_REASON:
 >   ERROR: Circular dependency detected
 >   *** Error code 1
 >
 > This is because net/tnftp wants libncurses but libnbcurses wants tnftp
 > for download.  I propose to completely remove interactive features
 > from net/tnftp.  tnftp client with such features should be separated
 > into a new individual package.
 >
 > Working patch is below.
 >
 > This problem is also not specific to Interix and may happen
 > on other platforms too.
 >
 >> Fix:
 > Index: net/tnftp/Makefile
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/net/tnftp/Makefile,v
 > retrieving revision 1.25
 > diff -u -r1.25 Makefile
 > --- net/tnftp/Makefile       19 Jun 2008 18:36:51 -0000      1.25
 > +++ net/tnftp/Makefile       13 Sep 2008 07:22:02 -0000
 > @@ -20,7 +20,7 @@
 > GNU_CONFIGURE=               yes
 > NO_CHECKSUM=         yes
 > CHECK_PERMS=         no
 > -
 > +CONFIGURE_ARGS+=    --disable-editcomplete
 > OPSYSVARS+=          MAKE_ENV
 > MAKE_ENV.SunOS+=     CPPFLAGS=""
 >
 > @@ -30,17 +30,4 @@
 >      @${CP} -R ${FILESDIR} ${WRKSRC}
 >      @${RM} -f ${WRKSRC}/INSTALL
 >
 > -# Use readline/builtin.mk to check for an editline library on the
 > -# system.  If we use the system editline library, then use the  
 > built-in
 > -# termcap library.
 > -#
 > -CHECK_BUILTIN.readline:=    yes
 > -.include "../../devel/readline/builtin.mk"
 > -CHECK_BUILTIN.readline:=    no
 > -
 > -.if !empty(BUILTIN_LIB_FOUND.edit:M[yY][eE][sS])
 > -USE_BUILTIN.termcap=        yes
 > -.endif
 > -
 > -.include "../../mk/termcap.buildlink3.mk"
 > .include "../../mk/bsd.pkg.mk"
 >