pkg/39575: ALL_ENV is used by gcc.mk before being defined

[roland.illig%gmx.de@localhost]

>Number:         39575
>Category:       pkg
>Synopsis:       ALL_ENV is used by gcc.mk before being defined
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 17 23:20:01 +0000 2008
>Originator:     Roland Illig
>Release:        pkgsrc-current
>Organization:
>Environment:
Linux bacc 2.6.24-19-generic #1 SMP Wed Aug 20 17:53:40 UTC 2008 x86_64 
GNU/Linux
LANG=de_DE.UTF-8

>Description:
When determining the compiler version, the user's locale is used instead of the 
C locale. This is because when loading gcc.mk, neither of the variables SETENV 
nor ALL_ENV are defined.

This only happens for the package where bmake is called directly. For 
dependencies, all goes well.
>How-To-Repeat:
$ ssh linux-x86_64
$ cd /usr/pkgsrc/devel/bison
$ bmake show-all-gcc | grep _GCC_VERSION
  def   _GCC_VERSION = 0
  def   _GCC_VERSION_STRING = 0
 
>Fix:
Define COMMON_ENV in bsd.prefs.mk and use that instead of ALL_ENV.