pkg/39595: Cairos 1.6.4 pkgsrc makefile duplicate test with upstream autoconf

[manu%fra.net@localhost]

>Number:         39595
>Category:       pkg
>Synopsis:       Cairos 1.6.4 pkgsrc makefile duplicate test with upstream 
>autoconf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 21 17:20:00 +0000 2008
>Originator:     Emmanuel Kasper
>Release:        Darwin 7.9
>Organization:
>Environment:
Darwin leo.libera.cc 7.9.0 Darwin Kernel Version 7.9.0: Wed Mar 30 20:11:17 PST 
2005; root:xnu/xnu-517.12.7.obj~1/RELEASE_PPC  Power Macintosh powerpc
>Description:
I hit this by try trying to disable the quartz backend.

Cairo's Makefile include the following snippet:

PLIST_VARS+=           carbon 
.if exists(/System/Library/Frameworks/Carbon.framework)
CONFIGURE_ARGS+=       --enable-quartz
CONFIGURE_ARGS+=       --enable-quartz-font
CONFIGURE_ARGS+=       --enable-quartz-image
PLIST.carbon=          yes
.endif 

I think the purpose of this is to build the Quartz backend on an OSX machine.
However commenting this lines still build the quartz backend.

Having a look at configure.in shows: 

CAIRO_BACKEND_ENABLE(quartz, Quartz, quartz, QUARTZ_SURFACE, auto, [
  dnl There is no pkgconfig for quartz; lets do a header check
  AC_CHECK_HEADER(ApplicationServices/ApplicationServices.h, , [use_quartz="no (
ApplicationServices framework not found)"])
  if test "x$use_quartz" != "xyes" ; then
    dnl check for CoreGraphics as a separate framework
    AC_CHECK_HEADER(CoreGraphics/CoreGraphics.h, , [use_quartz="no (CoreGraphics
 framework not found)"])
    quartz_LIBS="-Xlinker -framework -Xlinker CoreGraphics"
  else
    quartz_LIBS="-Xlinker -framework -Xlinker ApplicationServices"
  fi
])

CAIRO_BACKEND_ENABLE(quartz_font, Quartz font, quartz-font, QUARTZ_FONT, auto, [
  use_quartz_font=$use_quartz
])

CAIRO_BACKEND_ENABLE(quartz_image, Quartz Image, quartz-image, QUARTZ_IMAGE_SURF
ACE, no, [
  use_quartz_image=$use_quartz
])


as this test is already done by upstream autoconf, we should remove it from the 
pkgsrc infrastructure 


>How-To-Repeat:
bmake configure in cairo

>Fix:
remove quartz test