pkg/39740: perl 5.10: p5-Readonly-XS no longer works - incorrect usage of Carp?

[sd4dfg2%hotmail.com@localhost]

>Number:         39740
>Category:       pkg
>Synopsis:       perl 5.10: p5-Readonly-XS no longer works - incorrect usage of 
>Carp?
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 13 18:10:00 +0000 2008
>Originator:     Rob Quinn
>Release:        Solaris 5.10, pkgsrc-current
>Organization:
>Environment:
>Description:
p5-Readonly-XS fails with reference to Carp.
>How-To-Repeat:
Install p5-Readonly and p5-Readonly-XS.

  %cat /tmp/test 
  #!/usr/pkg/bin/perl
  use Readonly;
  exit 0;

  %/tmp/test 
  String found where operator expected at 
/usr/pkg/lib/perl5/vendor_perl/5.10.0/sparc-solaris-thread-multi/Readonly/XS.pm 
line 36, near "Carp::croak "Readonly::XS is not a standalone module. You should 
not use it directly.""
        (Do you need to predeclare Carp::croak?)


Line 36 is:
  Carp::croak "Readonly::XS is not a standalone module. You should not use it 
directly.";


>Fix:
I think it's this issue discussed in perldelta:

     "warnings"
         The "warnings" pragma doesn't load "Carp" anymore. That
         means that code that used "Carp" routines without having
         loaded it at compile time might need to be adjusted;
         typically, the following (faulty) code won't work
         anymore, and will require parentheses to be added after
         the function name:

             use warnings;
             require Carp;
             Carp::confess 'argh';