pkg/39785: pkg_install/libnbcompat: Solaris 10 gai_strerror decleration mismatch

[sd4dfg2%hotmail.com@localhost]

>Number:         39785
>Category:       pkg
>Synopsis:       pkg_install/libnbcompat: Solaris 10 gai_strerror decleration 
>mismatch
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 22 12:45:00 +0000 2008
>Originator:     Rob Quinn
>Release:        Solaris 5.10, pkgsrc-current
>Organization:
>Environment:
>Description:
pkg_install fails to build on Solaris 10.
>How-To-Repeat:
:/usr/pkgsrc/pkgtools/pkg_install #bmake
[...]
/usr/obj/pkg/pkgtools/pkg_install/work/libarchive/libarchive 
-I/usr/obj/pkg/pkgtools/pkg_install/work/libfetch -DHAVE_NBCOMPAT_H=1 
-I/usr/obj/pkg/pkgtools/pkg_install/work/libnbcompat -I. -I.  -O -mv8 -pipe 
-DHAVE_CONFIG_H -c getaddrinfo.c
In file included from getaddrinfo.c:41:
/usr/obj/pkg/pkgtools/pkg_install/work/libnbcompat/nbcompat/netdb.h:178: error: 
conflicting types for 'gai_strerror'
/usr/include/netdb.h:329: error: previous declaration of 'gai_strerror' was here
/usr/obj/pkg/pkgtools/pkg_install/work/libnbcompat/nbcompat/netdb.h:178: error: 
conflicting types for 'gai_strerror'
/usr/include/netdb.h:329: error: previous declaration of 'gai_strerror' was here
*** Error code 1

Stop.
bmake: stopped in /usr/obj/pkg/pkgtools/pkg_install/work/libnbcompat
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/pkgtools/pkg_install
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/pkgtools/pkg_install

>Fix:
Despite what the man page says, Solaris 10 declares gai_strerror like this:

%grep gai_strerror /usr/include/netdb.h
const char      *gai_strerror(int);
const char      *gai_strerror();

Solaris 9:
#grep gai_strerror /usr/include/netdb.h
char            *gai_strerror(int);
char            *gai_strerror();

Solaris 8:
%grep gai_strerror /usr/include/netdb.h
char            *gai_strerror(int);
char            *gai_strerror();