pkg/39973: security/mcrypt bad grammar in compilation (config) error abort

[kre%munnari.OZ.AU@localhost]

>Number:         39973
>Category:       pkg
>Synopsis:       security/mcrypt bad grammar in compilation (config) error abort
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 20 10:55:02 +0000 2008
>Originator:     Robert Elz
>Release:        NetBSD 4.0_STABLE  (pkgsrc current within past few hours).
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        As reported in PR pkg/39909 by Volkmar Seifert security/mcrypt
        fails to compile (configure) currently.

        Aside from that, the error by which it reports failure to
        compile has bad grammar ...

        .../.buildlink/include/mutils/mincludes.h:112:2: error: #error Cannot 
find either INT_MAX, INTMAX, or MAXINT

        "either" is only properly used with alternatives (2 options).
        Here there are three.   The error should say
                Cannot find any of INT_MAX, INTMAX, or MAXINT
        or if someone really needs to use "either"
                Cannot find either INT_MAX, or either INTMAX or MAXINT
        the latter giving alternatives, in which the 2nd alternative
        itself has alternatives.

>How-To-Repeat:
        Attempt to build security/mcrypt currently.

        I used pkg_comp with NetBSD 4.0 release sets (without X sets,
        but with X11_TYPE=modular - not that mcrypt is going to care)
        Volkmar Seifert apparently used NetBSD 3.1 - so NetBSD version
        seems to be irrelevant.

        Just build it - try to build it, the error occurs.

>Fix:
        Either fix the grammar in the #error line, or just fix PR 39909 so
        no-one ever notices...