pkg/41403: mencoder can't handle multimedia file with AAC audio, while mplayer can play the same file.

[bsh%grotto.jp@localhost]

>Number:         41403
>Category:       pkg
>Synopsis:       mencoder can't handle multimedia file with AAC audio, while 
>mplayer can play the same file.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 10 16:15:01 +0000 2009
>Originator:     Hiroyuki Bessho
>Release:        NetBSD 4.0_STABLE
>Organization:
        Not so organized.
>Environment:
System: NetBSD akoudai.a.grotto.jp 4.0_STABLE NetBSD 4.0_STABLE (AKOUDAI) #3: 
Mon Apr 21 09:09:49 JST 2008 
bsh%akoudai.a.grotto.jp@localhost:/u1/proj/netbsd/tnf/4.x/src/sys/arch/amd64/compile/obj.amd64/AKOUDAI
 amd64
pkgsrc-2009Q1
Architecture: x86_64
Machine: amd64
>Description:
Mencoder can't convert multimedia files when the file has an AAC audio part.
Error message from mencoder:
  ==========================================================================
  Requested audio codec family [faad] (afm=faad) not available.
  Enable it at compilation.
  Cannot find codec for audio format 0x6134706D.
  Read DOCS/HTML/en/codecs.html!
  ==========================================================================

Mplayer (which shares a part of codes with mencoder) can play the same
multimedia file without problems.

This is because mencoder is configured with --disable-faad-external
and --disable-faad-internal.  "make show-options" at
multimedia/mencoder doesn't list any faad related options.

>How-To-Repeat:
  run mencoder to convert MP4 files.

  for example:
   mencoder -lavfopts format=psp -of lavf -ovc lavc -lavcopts \
        vcodec=libx264:acodec=libfaac:autoaspect video.mp4


>Fix:
  following patch enables faad also for mencoder.

Index: multimedia/mplayer-share/options.mk
===================================================================
RCS file: /u00/tnfcvs/pkgsrc/multimedia/mplayer-share/options.mk,v
retrieving revision 1.35
diff -u -r1.35 options.mk
--- multimedia/mplayer-share/options.mk 3 Jan 2009 15:18:18 -0000       1.35
+++ multimedia/mplayer-share/options.mk 10 May 2009 16:04:52 -0000
@@ -20,11 +20,12 @@
 .endif

 # Set options based on the specific package being built.
-.if !empty(PKGNAME:M*mplayer*)
 PKG_OPTIONS_OPTIONAL_GROUPS=   faadgroup
 PKG_OPTIONS_GROUP.faadgroup=   faad mplayer-internal-faad
 PKG_SUGGESTED_OPTIONS+=                mplayer-internal-faad

+.if !empty(PKGNAME:M*mplayer*)
+
 PKG_SUPPORTED_OPTIONS+=        aalib esound ggi mplayer-menu nas pulseaudio sd\
l

 .  if ${OPSYS} != "SunOS"