pkg/41496: lang/tcl does not compile under Solaris 9

[andrew%ugh.net.au@localhost]

>Number:         41496
>Category:       pkg
>Synopsis:       lang/tcl does not compile under Solaris 9
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 27 19:50:00 +0000 2009
>Originator:     Andrew
>Release:        Solaris 9
>Organization:
UgH!
>Environment:
SunOS 5.9 Generic_122300-33
>Description:
Trying to build expect which depends on tcl. Error from tcl build is:

 gcc -c -O -O -I/usr/pkg/work/lang/tcl/work/.buildlink/gcc34/include 
-I/usr/pkg/work/lang/tcl/work/.buildlink/gcc34/lib/gcc/sparc-sun-solaris2.9/3.4.6/include
 -I/usr/pkg/work/lang/tcl/work/.buildlink/include -pipe -DTCL_DBGX= -Wall 
-Wno-implicit-int -fno-strict-aliasing -fPIC -I. 
-I/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic 
-I/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix -DHAVE_LIMITS_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_SYS_PARAM_H=1 -D_REENTRANT=1 
-D_POSIX_PTHREAD_SEMANTICS=1 "-DTCL_WIDE_INT_TYPE=long long" 
-DHAVE_STRUCT_DIRENT64=1 -DHAVE_STRUCT_STAT64=1 -DHAVE_OPEN64=1 
-DHAVE_LSEEK64=1 -DHAVE_TYPE_OFF64_T=1 -DWORDS_BIGENDIAN=1 -DHAVE_GETCWD=1 
-DHAVE_OPENDIR=1 -DHAVE_STRSTR=1 -DHAVE_STRTOL=1 -DHAVE_STRTOLL=1 
-DHAVE_STRTOULL=1 -DHAVE_TMPNAM=1 -DHAVE_WAITPID=1 -DUSE_TERMIOS=1 
-DHAVE_SYS_TIME_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_TZNAME=1 -DHAVE_GMTIME_R=1 
-DHAVE_LOCALTIME_R=1 -DHAVE_TIMEZONE_VAR=1 -DHAVE_ST_BLKSIZE=1 -DSTDC_HEADERS=1 
-DNO_UNION_WAIT=1 -DHAVE_SIGNED_CHAR=1 -DHAVE_
 LANGINFO=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_SYS_FILIO_H=1 "-DTCL_SHLIB_EXT=\".so\"" 
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclExecute.c  -fPIC -DPIC 
-o .libs/tclExecute.o
 In file included from 
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tcl.h:159,
                  from 
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclInt.h:33,
                  from 
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclExecute.c:17:
/usr/pkg/work/lang/tcl/work/.buildlink/gcc34/lib/gcc/sparc-sun-solaris2.9/3.4.6/include/stdio.h:34:
 warning: ignoring #pragma ident 
In file included from 
/usr/pkg/work/lang/tcl/work/.buildlink/gcc34/lib/gcc/sparc-sun-solaris2.9/3.4.6/include/limits.h:11,
                 from 
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclInt.h:42,
                 from 
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclExecute.c:17:
/usr/pkg/work/lang/tcl/work/.buildlink/gcc34/lib/gcc/sparc-sun-solaris2.9/3.4.6/include/syslimits.h:26:
 warning: ignoring #pragma ident 
In file included from 
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclMath.h:24,
                 from 
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclExecute.c:21:
/usr/pkg/work/lang/tcl/work/.buildlink/gcc34/lib/gcc/sparc-sun-solaris2.9/3.4.6/include/math.h:23:
 warning: ignoring #pragma ident 
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclExecute.c:425: error: 
`hypot' undeclared here (not in a function)
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclExecute.c:425: error: 
initializer element is not constant
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclExecute.c:425: error: 
(near initialization for `tclBuiltinFuncTable[10].clientData')
/usr/pkg/work/lang/tcl/work/tcl8.4.18/unix/../generic/tclExecute.c:425: error: 
initializer element is not constant

>How-To-Repeat:
cd lang/tcl && bmake
>Fix:
My workaround was to edit unix/Makefile in the word directory and add 
-D__EXTENSIONS__ to CFLAGS. TCL looks like it uses configure so this is 
obviously not the correct fix but is much simpler than working out a proper 
test for configure.