Re: pkg/38371 building math/lapack hangs on Linux (unfinite loop)

[Aleksey Cheusov <cheusov%tut.by@localhost>]

The following reply was made to PR pkg/38371; it has been noted by GNATS.

From: Aleksey Cheusov <cheusov%tut.by@localhost>
To: tnn%netbsd.org@localhost, obache%NetBSD.org@localhost, 
adam%NetBSD.org@localhost, gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: Re: pkg/38371 building math/lapack hangs on Linux (unfinite loop)
Date: Fri, 16 Oct 2009 01:14:53 +0300

 First of all, I'd like to say that this problem is not specific to Linux
 and is reproducible on other OSes and non-gcc compilers too.
 
 This problems is caused by incorrect optimization flags passed to
 fortran compiler for dlamch.f and slamch.f source files.
 
 In upstream these files are compiled without optimization and this is
 correct. The error is introduced by pkgsrc's buggy patches/patch-ad
 where ${NOOPT} is removed.
 
 The following patch solves the problem.
 Also it makes sense to explicitely
 set NOOPT to -O0 or something similar.
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/math/lapack/Makefile,v
 retrieving revision 1.27
 diff -u -r1.27 Makefile
 --- Makefile   22 Feb 2009 14:15:28 -0000      1.27
 +++ Makefile   15 Oct 2009 22:15:42 -0000
 @@ -13,7 +13,6 @@
  
  PKG_INSTALLATION_TYPES=       overwrite pkgviews
  PKG_DESTDIR_SUPPORT=  user-destdir
 -NOT_FOR_BULK_PLATFORM=        Linux-*-*
  
  USE_LANGUAGES=                c fortran
  USE_LIBTOOL=          YES
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/math/lapack/distinfo,v
 retrieving revision 1.11
 diff -u -r1.11 distinfo
 --- distinfo   12 Aug 2008 21:32:04 -0000      1.11
 +++ distinfo   15 Oct 2009 22:15:42 -0000
 @@ -6,4 +6,4 @@
  SHA1 (patch-aa) = 75671f2cc3233241f03ecab5a5d79cb505eece15
  SHA1 (patch-ab) = fd5989eaafc622f29284759f538ccc0f11dfe624
  SHA1 (patch-ac) = 649f7e40142936af49c8c9dbec376bdd1a11b05a
 -SHA1 (patch-ad) = e727bd3e83351f03c3a6cf2b8d5f33d5cbbc37da
 +SHA1 (patch-ad) = 52e3974be46c9dec983d2b56d769efe3d7d3eda5
 Index: patches/patch-ad
 ===================================================================
 RCS file: /cvsroot/pkgsrc/math/lapack/patches/patch-ad,v
 retrieving revision 1.1
 diff -u -r1.1 patch-ad
 --- patches/patch-ad   10 Dec 2007 17:50:31 -0000      1.1
 +++ patches/patch-ad   15 Oct 2009 22:15:42 -0000
 @@ -1,14 +1,17 @@
 -$NetBSD: patch-ad,v 1.1 2007/12/10 17:50:31 adam Exp $
 -
 ---- INSTALL/Makefile.orig     2007-11-22 18:51:41.000000000 +0100
 -+++ INSTALL/Makefile
 -@@ -29,7 +29,6 @@ testversion: ilaver.o LAPACK_version.o
 +--- /tmp/obj_pkgsrc/math/lapack/work/lapack-lite-3.1.1/INSTALL/Makefile.orig  
2007-02-26 20:19:47.000000000 +0200
 ++++ /tmp/obj_pkgsrc/math/lapack/work/lapack-lite-3.1.1/INSTALL/Makefile       
2009-10-16 00:59:42.534270840 +0300
 +@@ -29,7 +29,10 @@
   clean:
        rm -f *.o
   
  -slamch.o: slamch.f ; $(FORTRAN) $(NOOPT) -c $< -o $@
  -dlamch.o: dlamch.f ; $(FORTRAN) $(NOOPT) -c $< -o $@
 - 
 +-
  -.f.o: ; $(FORTRAN) $(OPTS) -c $< -o $@
 ++slamch.o: slamch.f
 ++     ${LIBTOOL} --mode=compile --tag=CC $(FC) $(NOOPT) -c $< -o $@
 ++dlamch.o: dlamch.f
 ++     ${LIBTOOL} --mode=compile --tag=CC $(FC) $(NOOPT) -c $< -o $@
 ++ 
  +.f.o:
  +     ${LIBTOOL} --mode=compile --tag=CC ${FC} ${FFLAGS} -c $<
 
 -- 
 Best regards, Aleksey Cheusov.