pkg/42256: check-files with /usr/pkgsrc mounted read-only

[Steven Drake <sdrake%xnet.co.nz@localhost>]

>Number:         42256
>Category:       pkg
>Synopsis:       check-files with /usr/pkgsrc mounted read-only
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 01 23:45:00 +0000 2009
>Originator:     Steven Drake
>Release:        pkgsrc-2009Q3
>Organization:
>Environment:
System: Linux idran 2.6.30 #2 PREEMPT Sun Aug 9 18:32:44 NZST 2009 i686 
pentium4 i386 GNU/Linux
Architecture: pentium4
Machine: i686
C library: GNU C Library stable release version 2.10.1, by Roland McGrath et al.
>Description:
With CHECK_FILES=yes and /usr/pkgsrc mounted read-only the following problem
and message when building.

===> Deinstalling for python25-2.5.4nb1
Running /usr/pkg/sbin/pkg_delete -K /var/pkg/db/pkg  python25-2.5.4nb1
pkg_delete: Couldn't remove /usr/pkg/lib/python2.5/lib-dynload/dbm.so
/bin/rm: cannot remove `check-files-pre-message': Read-only file system
/bin/rm: cannot remove `check-files-post-message': Read-only file system
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/lang/python25
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/lang/python25

>How-To-Repeat:

>Fix:
The following patch.

Index: pkgsrc/mk/check/check-files.mk
===================================================================
--- pkgsrc.orig/mk/check/check-files.mk
+++ pkgsrc/mk/check/check-files.mk
@@ -374,7 +374,8 @@ check-clean: check-files-clean
 check-files-clean:
        ${RUN}                                  \
        ${RM} -f ${_CHECK_FILES_ERRMSGS}                                \
-               ${_CHECK_FILES_PRE} ${_CHECK_FILES_POST}                \
+               ${_CHECK_FILES_PRE:Ncheck-files-pre-message}            \
+               ${_CHECK_FILES_POST:Ncheck-files-post-message}          \
                ${_CHECK_FILES_DIFF} ${_CHECK_FILES_ADDED}              \
                ${_CHECK_FILES_DELETED} ${_CHECK_FILES_EXPECTED}        \
                ${_CHECK_FILES_MISSING} ${_CHECK_FILES_MISSING_SKIP}    \



-- 
Steven