Re: pkg/42278 (print/acroread8 PLIST problems (file-check test))

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR pkg/42278; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: Tim Zingelman <tez%netbsd.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost, pkg-manager%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost,
        gnats-admin%netbsd.org@localhost
Subject: Re: pkg/42278 (print/acroread8 PLIST problems (file-check test))
Date: Mon, 09 Nov 2009 21:50:02 +0700

     Date:        Mon, 9 Nov 2009 07:13:33 -0600
     From:        Tim Zingelman <tez%netbsd.org@localhost>
     Message-ID:  
<f66ce35c0911090513t69dbfefewade74d55fb81708f%mail.gmail.com@localhost>
 
   | Please try this patch and see if it resolves your issue (the missing
   | filenames are in PLIST.Linux already, so this should cause them to be
   | included.)
 
 Thanks, it does, but unfortunately, setting PLIST_SRC (even with +=)
 caused the default value for it to be ignored... so the effect was to
 invert the set of PLIST problems - all the errors from before went away,
 but every other file was now missing from the PLIST.
 
 The patch below seems to work though, but I'm not sure if this is the
 best way to do it.
 
 kre
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/NetBSD/pkgsrc/print/acroread8/Makefile,v
 retrieving revision 1.9
 diff -u -r1.9 Makefile
 --- Makefile   4 Nov 2009 23:37:53 -0000       1.9
 +++ Makefile   9 Nov 2009 14:46:08 -0000
 @@ -32,11 +32,14 @@
  EMUL_MODULES.linux=   compat cups gtk2 locale
  EMUL_REQD=            suse>=10.0
  
 +PLIST_SRC=             ${PLIST_SRC_DFLT}
 +
  .include "../../mk/bsd.prefs.mk"
  
  .if ${EMUL_PLATFORM} == "linux-i386"
  DISTNAME=     AdobeReader_enu-8.1.7-1.i486
  PLATFORM=     intellinux
 +PLIST_SRC+=   PLIST.Linux
  .elif ${EMUL_PLATFORM} == "solaris-sparc"
  DISTNAME=     AdobeReader_enu-8.1.7-1.sparc
  PLATFORM=     sparcsolaris